From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, jassisinghbrar@gmail.com
Cc: Sasha Levin <sashal@kernel.org>,
sudeep.holla@arm.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-tegra@vger.kernel.org,
joonwonkang@google.com, Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 6.18.y] mailbox: Fix NULL message support in mbox_send_message()
Date: Fri, 8 May 2026 22:08:38 -0400 [thread overview]
Message-ID: <20260509015927.agent5-0002@kernel.org> (raw)
In-Reply-To: <20260507062107.2927600-1-joonwonkang@google.com>
On Thu, May 07, 2026 at 06:21:07AM +0000, Joonwon Kang wrote:
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ff292b9e0be9..7a2baeca2ba4 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -361,7 +361,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
> if (pchan->chan.rx_alloc)
> handle = write_response(pchan);
>
> - if (chan->active_req) {
> + if (chan->active_req != MBOX_NO_MSG) {
> pcc_header = chan->active_req;
> if (pcc_header->flags & PCC_CMD_COMPLETION_NOTIFY)
> mbox_chan_txdone(chan, 0);
This pcc.c hunk does not apply on 6.18.y: commit 5378bdf6a611 ("mailbox/pcc:
support mailbox management of the shared buffer") was reverted upstream by
f82c3e62b6b8, and that revert is already queued in 6.18 as 2cafad617431.
write_response() and the active_req-driven txdone path no longer exist in
pcc_mbox_irq() on 6.18, so this hunk is both syntactically inapplicable and
semantically unnecessary.
Could you send a v2 omitting the pcc.c hunk? The other three hunks
(mailbox.c, tegra-hsp.c, mailbox_controller.h) apply cleanly and I'm
happy to queue those for 6.18.y.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-05-09 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 6:21 [PATCH 6.18.y] mailbox: Fix NULL message support in mbox_send_message() Joonwon Kang
2026-05-09 2:08 ` Sasha Levin [this message]
2026-05-10 5:50 ` Joonwon Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509015927.agent5-0002@kernel.org \
--to=sashal@kernel.org \
--cc=dianders@chromium.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=joonwonkang@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.