From: Nathan Chancellor <nathan@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Subject: MIPS: non-default visibility warnings from tip of tree binutils around __memcpy / __memset
Date: Sat, 9 May 2026 20:25:17 +0800 [thread overview]
Message-ID: <20260509122517.GA1108596@ax162> (raw)
Hi,
After binutils commit c4150acbda1 ("gas/ELF: warn upon non-default
visibility of local symbols") [1], I am seeing the following warnings:
$ make -skj"$(nproc)" ARCH=mips CROSS_COMPILE=mips-linux- mrproper defconfig arch/mips/lib/
Assembler messages:
{standard input}: Warning: local symbol `__memset' has non-default visibility
Assembler messages:
{standard input}: Warning: local symbol `__memcpy' has non-default visibility
Should the '.hidden' directive for these symbols be removed, as it seems
unnecessary for local symbols? Or is there a different fix for this?
This resolves the warnings for me but I figured I would ask before
sending it as a formal patch.
diff --git a/arch/mips/lib/memcpy.S b/arch/mips/lib/memcpy.S
index a4b4e805ff13..84f85aba6f4b 100644
--- a/arch/mips/lib/memcpy.S
+++ b/arch/mips/lib/memcpy.S
@@ -274,7 +274,6 @@
/* initialize __memcpy if this the first time we execute this macro */
.ifnotdef __memcpy
.set __memcpy, 1
- .hidden __memcpy /* make sure it does not leak */
.endif
/*
@@ -538,7 +537,6 @@
.if __memcpy == 1
END(memcpy)
.set __memcpy, 0
- .hidden __memcpy
.endif
.Ll_exc_copy\@:
diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S
index 79405c32cc85..ab087406da66 100644
--- a/arch/mips/lib/memset.S
+++ b/arch/mips/lib/memset.S
@@ -89,7 +89,6 @@
/* Initialize __memset if this is the first time we call this macro */
.ifnotdef __memset
.set __memset, 1
- .hidden __memset /* Make sure it does not leak */
.endif
sltiu t0, a2, STORSIZE /* very small region? */
@@ -231,7 +230,6 @@
.if __memset == 1
END(memset)
.set __memset, 0
- .hidden __memset
.endif
#ifdef CONFIG_CPU_NO_LOAD_STORE_LR
--
[1]: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=c4150acbda1b3ce0602f79cbb7700b39e577be7e
--
Cheers,
Nathan
reply other threads:[~2026-05-09 12:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509122517.GA1108596@ax162 \
--to=nathan@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.