diff for duplicates of <202605092030.FAH71Jou-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 6b865ce..f097154 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: e98d21c170b01ddef366f023bbfcf6b31509fa83 commit: 1a83d226268cfb9ea546febe6515f39584df8fd2 [4172/4394] loop: check refcount in __loop_clr_fd() and lo_rw_aio() -:::::: branch date: 24 hours ago -:::::: commit date: 2 days ago config: m68k-randconfig-r073-20260509 (https://download.01.org/0day-ci/archive/20260509/202605092030.FAH71Jou-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.5.0 smatch: v0.5.0-9065-ge9cc34fd @@ -20,12 +14,8 @@ the same patch/commit), kindly add following tags New smatch warnings: drivers/block/loop.c:413 lo_rw_aio() error: we previously assumed 'file' could be null (see line 400) -Old smatch warnings: -drivers/block/loop.c:676 loop_attr_backing_file_show() warn: passing zero to 'PTR_ERR' - vim +/file +413 drivers/block/loop.c -bc07c10a3603a5 Ming Lei 2015-08-17 339 96f03c8cb29f2e Jens Axboe 2025-11-24 340 static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, 96f03c8cb29f2e Jens Axboe 2025-11-24 341 loff_t pos, int rw) c3e6c11147f6f0 Ming Lei 2025-10-15 342 { @@ -89,6 +79,10 @@ bc07c10a3603a5 Ming Lei 2015-08-17 399 1a83d226268cfb Tetsuo Handa 2026-05-08 @400 if (!file) 1a83d226268cfb Tetsuo Handa 2026-05-08 401 pr_err("%s(loop%d) starting %s with NULL file (already cleared?)\n", 1a83d226268cfb Tetsuo Handa 2026-05-08 402 __func__, lo->lo_number, rw == ITER_SOURCE ? "write" : "read"); + +presumably this is debug code which isn't going to be merged but + + 1a83d226268cfb Tetsuo Handa 2026-05-08 403 else if (!file_count(file)) 1a83d226268cfb Tetsuo Handa 2026-05-08 404 pr_err("%s(loop%d) starting %s with raw_refcnt=0x%lx (already released?)\n", 1a83d226268cfb Tetsuo Handa 2026-05-08 405 __func__, lo->lo_number, rw == ITER_SOURCE ? "write" : "read", @@ -102,6 +96,9 @@ c4706c5058a7bd Ming Lei 2025-07-16 412 kiocb_start_write(&cmd->ioc 7c98f7cb8fda96 Miklos Szeredi 2023-08-28 @413 ret = file->f_op->write_iter(&cmd->iocb, &iter); 39d86db34e41b9 Ming Lei 2025-05-27 414 } else 7c98f7cb8fda96 Miklos Szeredi 2023-08-28 415 ret = file->f_op->read_iter(&cmd->iocb, &iter); + +it file is NULL then it's going to crash here. + bc07c10a3603a5 Ming Lei 2015-08-17 416 92d773324b7edb Shaohua Li 2017-09-01 417 lo_rw_aio_do_completion(cmd); 92d773324b7edb Shaohua Li 2017-09-01 418 @@ -109,13 +106,6 @@ bc07c10a3603a5 Ming Lei 2015-08-17 419 if (ret != -EIOCBQUEUED) 6b19b766e8f077 Jens Axboe 2021-10-21 420 lo_rw_aio_complete(&cmd->iocb, ret); f2fed441c69b92 Christoph Hellwig 2025-04-09 421 return -EIOCBQUEUED; bc07c10a3603a5 Ming Lei 2015-08-17 422 } -bc07c10a3603a5 Ming Lei 2015-08-17 423 - -:::::: The code at line 413 was first introduced by commit -:::::: 7c98f7cb8fda964fbc60b9307ad35e94735fa35f remove call_{read,write}_iter() functions - -:::::: TO: Miklos Szeredi <mszeredi@redhat.com> -:::::: CC: Al Viro <viro@zeniv.linux.org.uk> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index c9cc5ac..a9c528e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,15 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[linux-next:master 4172/4394] drivers/block/loop.c:413 lo_rw_aio() error: we previously assumed 'file' could be null (see line 400)\0" - "Date\0Sat, 09 May 2026 20:56:05 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Sat, 9 May 2026 16:19:52 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master\n" "head: e98d21c170b01ddef366f023bbfcf6b31509fa83\n" "commit: 1a83d226268cfb9ea546febe6515f39584df8fd2 [4172/4394] loop: check refcount in __loop_clr_fd() and lo_rw_aio()\n" - ":::::: branch date: 24 hours ago\n" - ":::::: commit date: 2 days ago\n" "config: m68k-randconfig-r073-20260509 (https://download.01.org/0day-ci/archive/20260509/202605092030.FAH71Jou-lkp@intel.com/config)\n" "compiler: m68k-linux-gcc (GCC) 12.5.0\n" "smatch: v0.5.0-9065-ge9cc34fd\n" @@ -28,12 +23,8 @@ "New smatch warnings:\n" "drivers/block/loop.c:413 lo_rw_aio() error: we previously assumed 'file' could be null (see line 400)\n" "\n" - "Old smatch warnings:\n" - "drivers/block/loop.c:676 loop_attr_backing_file_show() warn: passing zero to 'PTR_ERR'\n" - "\n" "vim +/file +413 drivers/block/loop.c\n" "\n" - "bc07c10a3603a5 Ming Lei 2015-08-17 339 \n" "96f03c8cb29f2e Jens Axboe 2025-11-24 340 static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd,\n" "96f03c8cb29f2e Jens Axboe 2025-11-24 341 \t\t loff_t pos, int rw)\n" "c3e6c11147f6f0 Ming Lei 2025-10-15 342 {\n" @@ -97,6 +88,10 @@ "1a83d226268cfb Tetsuo Handa 2026-05-08 @400 \tif (!file)\n" "1a83d226268cfb Tetsuo Handa 2026-05-08 401 \t\tpr_err(\"%s(loop%d) starting %s with NULL file (already cleared?)\\n\",\n" "1a83d226268cfb Tetsuo Handa 2026-05-08 402 \t\t __func__, lo->lo_number, rw == ITER_SOURCE ? \"write\" : \"read\");\n" + "\n" + "presumably this is debug code which isn't going to be merged but\n" + "\n" + "\n" "1a83d226268cfb Tetsuo Handa 2026-05-08 403 \telse if (!file_count(file))\n" "1a83d226268cfb Tetsuo Handa 2026-05-08 404 \t\tpr_err(\"%s(loop%d) starting %s with raw_refcnt=0x%lx (already released?)\\n\",\n" "1a83d226268cfb Tetsuo Handa 2026-05-08 405 \t\t __func__, lo->lo_number, rw == ITER_SOURCE ? \"write\" : \"read\",\n" @@ -110,6 +105,9 @@ "7c98f7cb8fda96 Miklos Szeredi 2023-08-28 @413 \t\tret = file->f_op->write_iter(&cmd->iocb, &iter);\n" "39d86db34e41b9 Ming Lei 2025-05-27 414 \t} else\n" "7c98f7cb8fda96 Miklos Szeredi 2023-08-28 415 \t\tret = file->f_op->read_iter(&cmd->iocb, &iter);\n" + "\n" + "it file is NULL then it's going to crash here.\n" + "\n" "bc07c10a3603a5 Ming Lei 2015-08-17 416 \n" "92d773324b7edb Shaohua Li 2017-09-01 417 \tlo_rw_aio_do_completion(cmd);\n" "92d773324b7edb Shaohua Li 2017-09-01 418 \n" @@ -117,16 +115,9 @@ "6b19b766e8f077 Jens Axboe 2021-10-21 420 \t\tlo_rw_aio_complete(&cmd->iocb, ret);\n" "f2fed441c69b92 Christoph Hellwig 2025-04-09 421 \treturn -EIOCBQUEUED;\n" "bc07c10a3603a5 Ming Lei 2015-08-17 422 }\n" - "bc07c10a3603a5 Ming Lei 2015-08-17 423 \n" - "\n" - ":::::: The code at line 413 was first introduced by commit\n" - ":::::: 7c98f7cb8fda964fbc60b9307ad35e94735fa35f remove call_{read,write}_iter() functions\n" - "\n" - ":::::: TO: Miklos Szeredi <mszeredi@redhat.com>\n" - ":::::: CC: Al Viro <viro@zeniv.linux.org.uk>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -a59c045f9686d1cc9c013e1d4c3526570e9bea5f081d5ece7168fd2b628617d7 +f1abb3957e0812c4f704feeec4b8581156d98e9e3a8968992747cfa179938d4e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.