All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonwon Kang <joonwonkang@google.com>
To: jassisinghbrar@gmail.com
Cc: akpm@linux-foundation.org, dianders@chromium.org,
	joonwonkang@google.com,  linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, sudeep.holla@kernel.org
Subject: Re: [PATCH v5] mailbox: Make mbox_send_message() return error code when tx fails
Date: Sun, 10 May 2026 05:37:55 +0000	[thread overview]
Message-ID: <20260510053756.781317-1-joonwonkang@google.com> (raw)
In-Reply-To: <CABb+yY0Y0YHKviAaJiC8ZbJKCPnfJnQ2S-ifcsB-HFO3JzKJCA@mail.gmail.com>

> On Fri, May 8, 2026 at 4:02 AM Joonwon Kang <joonwonkang@google.com> wrote:
> >
> > When the mailbox controller failed transmitting message, the error code
> > was only passed to the client's tx done handler and not to
> > mbox_send_message() in blocking mode. For this reason, the function could
> > return a false success. This commit resolves the issue by introducing the
> > tx status and checking it before mbox_send_message() returns.
> >
> > This commit works with the premise that the multi-threads' access to a
> > channel in blocking mode is serialized by clients, not by the mailbox
> > APIs, since the current mbox_send_message() in blocking mode does not
> > support multi-threads.
> >
> > Cc: stable@vger.kernel.org
> >
> Not sure if this should go into stable. It is not a bug fix. See
> stable-kernel-rules

Alright, let me remove the Cc tag. Will try merging it to a stable branch
when needed later on.

Thanks,
Joonwon Kang

      reply	other threads:[~2026-05-10  5:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  9:02 [PATCH v5] mailbox: Make mbox_send_message() return error code when tx fails Joonwon Kang
2026-05-09  1:08 ` Jassi Brar
2026-05-10  5:37   ` Joonwon Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260510053756.781317-1-joonwonkang@google.com \
    --to=joonwonkang@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dianders@chromium.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.