From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, donald.hunter@gmail.com, horms@kernel.org,
sdf@fomichev.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] tools/ynl: add check-deps target to verify Makefile.deps completeness
Date: Sun, 10 May 2026 08:35:56 -0700 [thread overview]
Message-ID: <20260510083556.60e92d73@kernel.org> (raw)
In-Reply-To: <20260508204114.205896-3-sdf@fomichev.me>
On Fri, 8 May 2026 13:41:14 -0700 Stanislav Fomichev wrote:
> Add two make rules that detect missing entries in Makefile.deps:
>
> check-existing-deps-<family>: for families that already have CFLAGS,
> parse each force-included header for #include directives and verify
> that every included uapi header is either already listed in CFLAGS
> or findable by the compiler without -idirafter.
>
> check-new-deps-<family>: for families without CFLAGS, check whether
> their default uapi header (linux/<family>.h) exists in the kernel
> tree but is not findable by the compiler -- meaning it needs a new
> CFLAGS entry.
>
> (this is slop but I added extensive comments on how it works)
Would it be more suitable as a NIPA check? Or at least it'd feel less
bad to carry slop in NIPA than in the kernel tree. We already have a
test for YNL build.
next prev parent reply other threads:[~2026-05-10 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 20:41 [PATCH net-next 0/2] tools/ynl: add missing uapi header deps in Makefile.deps Stanislav Fomichev
2026-05-08 20:41 ` [PATCH net-next 1/2] " Stanislav Fomichev
2026-05-08 20:41 ` [PATCH net-next 2/2] tools/ynl: add check-deps target to verify Makefile.deps completeness Stanislav Fomichev
2026-05-10 15:35 ` Jakub Kicinski [this message]
2026-05-10 15:40 ` [PATCH net-next 0/2] tools/ynl: add missing uapi header deps in Makefile.deps patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510083556.60e92d73@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.