All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: Song Gao <gaosong@loongson.cn>,
	maobibo@loongson.cn, qemu-devel@nongnu.org,
	lixianglai@loongson.cn, chenhuacai@loongson.cn,
	Avihai Horon <avihaih@nvidia.com>, Thomas Huth <thuth@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v2 2/4] linux-headers: Update to Linux v7.1-rc1
Date: Sun, 10 May 2026 16:19:10 -0400	[thread overview]
Message-ID: <20260510161352-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c87311a3-b214-4705-8ed3-7386aea1056e@redhat.com>

On Sun, May 10, 2026 at 10:08:49PM +0200, Cédric Le Goater wrote:
> On 5/7/26 11:23, Song Gao wrote:
> > diff --git a/include/standard-headers/linux/virtio_ring.h b/include/standard-headers/linux/virtio_ring.h
> > index 22f6eb8ca7..7baf1968a3 100644
> > --- a/include/standard-headers/linux/virtio_ring.h
> > +++ b/include/standard-headers/linux/virtio_ring.h
> > @@ -31,7 +31,6 @@
> >    * SUCH DAMAGE.
> >    *
> >    * Copyright Rusty Russell IBM Corporation 2007. */
> > -#include <stdint.h>
> >   #include "standard-headers/linux/types.h"
> >   #include "standard-headers/linux/virtio_types.h"
> > @@ -200,7 +199,7 @@ static inline void vring_init(struct vring *vr, unsigned int num, void *p,
> >   	vr->num = num;
> >   	vr->desc = p;
> >   	vr->avail = (struct vring_avail *)((char *)p + num * sizeof(struct vring_desc));
> > -	vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16)
> > +	vr->used = (void *)(((unsigned long)&vr->avail->ring[num] + sizeof(__virtio16)
> >   		+ align-1) & ~(align - 1));
> >   }
> 
> The kernel commit 3c4629b68dbe ("virtio: uapi: avoid usage of
> libc types") changed this virtio header and this breaks the
> build on Windows :
> 
>   https://gitlab.com/legoater/qemu/-/jobs/14297040230
> 
> A fix could be to reintroduce 'uintptr_t' (available through
> osdep.h) by modifying the linux headers update script. Ideas ?
> 
> Thanks,
> 
> C.

Yea sorry ( Just add
#define VIRTIO_RING_NO_LEGACY
somewhere.


-- 
MST



  reply	other threads:[~2026-05-10 20:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  9:23 [PATCH v2 0/4] LoongArch : Add KVM DINTC support Song Gao
2026-05-07  9:23 ` [PATCH v2 1/4] scripts/update-linux-headers: Add typelimits.h Song Gao
2026-05-07  9:23 ` [PATCH v2 2/4] linux-headers: Update to Linux v7.1-rc1 Song Gao
2026-05-10 20:08   ` Cédric Le Goater
2026-05-10 20:19     ` Michael S. Tsirkin [this message]
2026-05-11  9:26       ` Cédric Le Goater
2026-05-11 10:48         ` Michael S. Tsirkin
2026-05-12 21:30   ` Cédric Le Goater
2026-05-13  1:04     ` gaosong
2026-05-07  9:23 ` [PATCH v2 3/4] target/loongarch: Add kvm support dintc Song Gao
2026-05-07  9:23 ` [PATCH v2 4/4] Add dintc kvm_irqchip_in_kernel support Song Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260510161352-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=chenhuacai@loongson.cn \
    --cc=clg@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=gaosong@loongson.cn \
    --cc=lixianglai@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.