From: Moksh Panicker <mokshpanicker.7@gmail.com>
To: linux-media@vger.kernel.org
Cc: mchehab@kernel.org, Moksh Panicker <mokshpanicker.7@gmail.com>
Subject: [PATCH v3] media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg
Date: Sun, 10 May 2026 17:24:05 +0000 [thread overview]
Message-ID: <20260510172405.72408-1-mokshpanicker.7@gmail.com> (raw)
In-Reply-To: <20260510162912.67381-1-mokshpanicker.7@gmail.com>
When mxl111sf_ctrl_msg() is called during early probe, state->d
may not yet be initialized, causing a null pointer dereference in
dvb_usbv2_generic_write() when it accesses d->usb_mutex.
Add a null check for d before proceeding with the USB transfer.
Fixes: d90b336f3f65 ("[media] mxl111sf: Fix driver to use heap allocate buffers for USB messages")
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/media/usb/dvb-usb-v2/mxl111sf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
index 870ac3c8b085..9908675c355e 100644
--- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
+++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
@@ -56,6 +56,9 @@ int mxl111sf_ctrl_msg(struct mxl111sf_state *state,
int wo = (rbuf == NULL || rlen == 0); /* write-only */
int ret;
+ if (!d)
+ return -ENODEV;
+
if (1 + wlen > MXL_MAX_XFER_SIZE) {
pr_warn("%s: len=%d is too big!\n", __func__, wlen);
return -EOPNOTSUPP;
--
2.34.1
next prev parent reply other threads:[~2026-05-10 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 16:24 [PATCH] media: mxl111sf: fix null pointer dereference in mxl111sf_ctrl_msg Moksh Panicker
2026-05-10 16:29 ` [PATCH v2] " Moksh Panicker
2026-05-10 16:29 ` syzbot
2026-05-10 17:24 ` Moksh Panicker [this message]
2026-05-11 10:13 ` [PATCH v4] " Moksh Panicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510172405.72408-1-mokshpanicker.7@gmail.com \
--to=mokshpanicker.7@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.