From: kernel test robot <lkp@intel.com>
To: Eric Dumazet <edumazet@google.com>
Cc: oe-kbuild-all@lists.linux.dev, 0day robot <lkp@intel.com>
Subject: net/core/drop_monitor.c:1164:42: error: passing argument 1 of 'register_trace_kfree_skb' from incompatible pointer type
Date: Mon, 11 May 2026 00:31:46 +0200 [thread overview]
Message-ID: <202605110041.nJRQPlCh-lkp@intel.com> (raw)
tree: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-constify-sk_skb_reason_drop-sock-parameter/20260510-230935
head: daff210bd24b88ed46a00a4f88b96722e9fe4a3d
commit: c2c014f764c7b7e3341d8ea76f1bcae8c284b06e net: constify sk_skb_reason_drop() sock parameter
date: 7 hours ago
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260511/202605110041.nJRQPlCh-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260511/202605110041.nJRQPlCh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605110041.nJRQPlCh-lkp@intel.com/
All errors (new ones prefixed by >>):
net/core/drop_monitor.c: In function 'net_dm_trace_on_set':
>> net/core/drop_monitor.c:1164:42: error: passing argument 1 of 'register_trace_kfree_skb' from incompatible pointer type [-Wincompatible-pointer-types]
1164 | rc = register_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ~~~^~~~~~~~~~~~~~~~~
| |
| void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)
In file included from include/trace/events/skb.h:10,
from net/core/drop_monitor.c:36:
include/linux/tracepoint.h:271:38: note: expected 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, const struct sock *)' but argument is of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)'
271 | register_trace_##name(void (*probe)(data_proto), void *data) \
| ~~~~~~~^~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:300:9: note: in expansion of macro '__DECLARE_TRACE_COMMON'
300 | __DECLARE_TRACE_COMMON(name, PARAMS(proto), PARAMS(args), PARAMS(data_proto)) \
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:526:9: note: in expansion of macro '__DECLARE_TRACE'
526 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^~~~~~~~~~~~~~~
include/linux/tracepoint.h:664:9: note: in expansion of macro 'DECLARE_TRACE_EVENT'
664 | DECLARE_TRACE_EVENT(name, PARAMS(proto), PARAMS(args))
| ^~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: in expansion of macro 'TRACE_EVENT'
24 | TRACE_EVENT(kfree_skb,
| ^~~~~~~~~~~
>> net/core/drop_monitor.c:1179:39: error: passing argument 1 of 'unregister_trace_kfree_skb' from incompatible pointer type [-Wincompatible-pointer-types]
1179 | unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ~~~^~~~~~~~~~~~~~~~~
| |
| void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)
include/linux/tracepoint.h:284:40: note: expected 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, const struct sock *)' but argument is of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)'
284 | unregister_trace_##name(void (*probe)(data_proto), void *data) \
| ~~~~~~~^~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:300:9: note: in expansion of macro '__DECLARE_TRACE_COMMON'
300 | __DECLARE_TRACE_COMMON(name, PARAMS(proto), PARAMS(args), PARAMS(data_proto)) \
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:526:9: note: in expansion of macro '__DECLARE_TRACE'
526 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^~~~~~~~~~~~~~~
include/linux/tracepoint.h:664:9: note: in expansion of macro 'DECLARE_TRACE_EVENT'
664 | DECLARE_TRACE_EVENT(name, PARAMS(proto), PARAMS(args))
| ^~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: in expansion of macro 'TRACE_EVENT'
24 | TRACE_EVENT(kfree_skb,
| ^~~~~~~~~~~
net/core/drop_monitor.c: In function 'net_dm_trace_off_set':
net/core/drop_monitor.c:1202:39: error: passing argument 1 of 'unregister_trace_kfree_skb' from incompatible pointer type [-Wincompatible-pointer-types]
1202 | unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ~~~^~~~~~~~~~~~~~~~~
| |
| void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)
include/linux/tracepoint.h:284:40: note: expected 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, const struct sock *)' but argument is of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)'
284 | unregister_trace_##name(void (*probe)(data_proto), void *data) \
| ~~~~~~~^~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:300:9: note: in expansion of macro '__DECLARE_TRACE_COMMON'
300 | __DECLARE_TRACE_COMMON(name, PARAMS(proto), PARAMS(args), PARAMS(data_proto)) \
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/tracepoint.h:526:9: note: in expansion of macro '__DECLARE_TRACE'
526 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^~~~~~~~~~~~~~~
include/linux/tracepoint.h:664:9: note: in expansion of macro 'DECLARE_TRACE_EVENT'
664 | DECLARE_TRACE_EVENT(name, PARAMS(proto), PARAMS(args))
| ^~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: in expansion of macro 'TRACE_EVENT'
24 | TRACE_EVENT(kfree_skb,
| ^~~~~~~~~~~
vim +/register_trace_kfree_skb +1164 net/core/drop_monitor.c
8e94c3bc922e70 Ido Schimmel 2019-08-17 1137
7c747838a55818 Ido Schimmel 2019-08-11 1138 static int net_dm_trace_on_set(struct netlink_ext_ack *extack)
9a8afc8d3962f3 Neil Horman 2009-03-11 1139 {
28315f7999870b Ido Schimmel 2019-08-11 1140 const struct net_dm_alert_ops *ops;
70c69274f354ec Ido Schimmel 2019-08-11 1141 int cpu, rc;
4b706372f18de5 Neil Horman 2010-07-20 1142
28315f7999870b Ido Schimmel 2019-08-11 1143 ops = net_dm_alert_ops_arr[net_dm_alert_mode];
28315f7999870b Ido Schimmel 2019-08-11 1144
cad456d5abbb63 Neil Horman 2012-05-17 1145 if (!try_module_get(THIS_MODULE)) {
965100966efe85 Ido Schimmel 2019-08-06 1146 NL_SET_ERR_MSG_MOD(extack, "Failed to take reference on module");
7c747838a55818 Ido Schimmel 2019-08-11 1147 return -ENODEV;
cad456d5abbb63 Neil Horman 2012-05-17 1148 }
cad456d5abbb63 Neil Horman 2012-05-17 1149
70c69274f354ec Ido Schimmel 2019-08-11 1150 for_each_possible_cpu(cpu) {
70c69274f354ec Ido Schimmel 2019-08-11 1151 struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
44075f56379388 Ido Schimmel 2019-08-11 1152 struct sk_buff *skb;
70c69274f354ec Ido Schimmel 2019-08-11 1153
28315f7999870b Ido Schimmel 2019-08-11 1154 INIT_WORK(&data->dm_alert_work, ops->work_item_func);
70c69274f354ec Ido Schimmel 2019-08-11 1155 timer_setup(&data->send_timer, sched_send_work, 0);
44075f56379388 Ido Schimmel 2019-08-11 1156 /* Allocate a new per-CPU skb for the summary alert message and
44075f56379388 Ido Schimmel 2019-08-11 1157 * free the old one which might contain stale data from
44075f56379388 Ido Schimmel 2019-08-11 1158 * previous tracing.
44075f56379388 Ido Schimmel 2019-08-11 1159 */
44075f56379388 Ido Schimmel 2019-08-11 1160 skb = reset_per_cpu_data(data);
44075f56379388 Ido Schimmel 2019-08-11 1161 consume_skb(skb);
70c69274f354ec Ido Schimmel 2019-08-11 1162 }
70c69274f354ec Ido Schimmel 2019-08-11 1163
28315f7999870b Ido Schimmel 2019-08-11 @1164 rc = register_trace_kfree_skb(ops->kfree_skb_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1165 if (rc) {
7c747838a55818 Ido Schimmel 2019-08-11 1166 NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to kfree_skb() tracepoint");
7c747838a55818 Ido Schimmel 2019-08-11 1167 goto err_module_put;
7c747838a55818 Ido Schimmel 2019-08-11 1168 }
cad456d5abbb63 Neil Horman 2012-05-17 1169
28315f7999870b Ido Schimmel 2019-08-11 1170 rc = register_trace_napi_poll(ops->napi_poll_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1171 if (rc) {
7c747838a55818 Ido Schimmel 2019-08-11 1172 NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to napi_poll() tracepoint");
7c747838a55818 Ido Schimmel 2019-08-11 1173 goto err_unregister_trace;
7c747838a55818 Ido Schimmel 2019-08-11 1174 }
7c747838a55818 Ido Schimmel 2019-08-11 1175
7c747838a55818 Ido Schimmel 2019-08-11 1176 return 0;
7c747838a55818 Ido Schimmel 2019-08-11 1177
7c747838a55818 Ido Schimmel 2019-08-11 1178 err_unregister_trace:
28315f7999870b Ido Schimmel 2019-08-11 @1179 unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1180 err_module_put:
9398e9c0b1d44e Ido Schimmel 2021-03-10 1181 for_each_possible_cpu(cpu) {
9398e9c0b1d44e Ido Schimmel 2021-03-10 1182 struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1183 struct sk_buff *skb;
9398e9c0b1d44e Ido Schimmel 2021-03-10 1184
8fa7292fee5c52 Thomas Gleixner 2025-04-05 1185 timer_delete_sync(&data->send_timer);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1186 cancel_work_sync(&data->dm_alert_work);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1187 while ((skb = __skb_dequeue(&data->drop_queue)))
9398e9c0b1d44e Ido Schimmel 2021-03-10 1188 consume_skb(skb);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1189 }
7c747838a55818 Ido Schimmel 2019-08-11 1190 module_put(THIS_MODULE);
7c747838a55818 Ido Schimmel 2019-08-11 1191 return rc;
7c747838a55818 Ido Schimmel 2019-08-11 1192 }
7c747838a55818 Ido Schimmel 2019-08-11 1193
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-05-10 22:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605110041.nJRQPlCh-lkp@intel.com \
--to=lkp@intel.com \
--cc=edumazet@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.