From: Shreenidhi Shedi <yesshedi@gmail.com>
To: gregkh@linuxfoundation.org, acme@kernel.org, linux@treblig.org,
mikhail.v.gavrilov@gmail.com
Cc: yesshedi@gmail.com, stable@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 6.1.y v2 11/18] perf session: Don't write to memory pointed to a const pointer
Date: Mon, 11 May 2026 12:40:44 +0530 [thread overview]
Message-ID: <20260511071051.537859-12-yesshedi@gmail.com> (raw)
In-Reply-To: <20260511071051.537859-1-yesshedi@gmail.com>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
commit f1321cce848c558fde4c0c6bcd5e53f3cefd3af2 upstream
Since it is freshly allocated just attribute it to a non-const pointer
and then change it via that pointer.
That way we avoid const-correctness warnings in recent glibc versions.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
---
tools/perf/util/session.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 1c4d124b1053..9d11cf2aab0c 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -2641,7 +2641,7 @@ bool perf_session__has_traces(struct perf_session *session, const char *msg)
int map__set_kallsyms_ref_reloc_sym(struct map *map, const char *symbol_name, u64 addr)
{
- char *bracket;
+ char *bracket, *name;
struct ref_reloc_sym *ref;
struct kmap *kmap;
@@ -2649,13 +2649,13 @@ int map__set_kallsyms_ref_reloc_sym(struct map *map, const char *symbol_name, u6
if (ref == NULL)
return -ENOMEM;
- ref->name = strdup(symbol_name);
+ ref->name = name = strdup(symbol_name);
if (ref->name == NULL) {
free(ref);
return -ENOMEM;
}
- bracket = strchr(ref->name, ']');
+ bracket = strchr(name, ']');
if (bracket)
*bracket = '\0';
--
2.54.0
next prev parent reply other threads:[~2026-05-11 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 7:10 [PATCH 6.1.y v2 00/18] Backport fixes for -Wdiscarded-qualifiers and -Wnonnull with newer glibc Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 01/18] libbpf: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 02/18] perf diff: Constify strchr() return variables Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 03/18] perf test bpf: Address error about non-null argument for epoll_pwait 2nd arg Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 04/18] perf list: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 05/18] perf trace: Deal with compiler const checks Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 06/18] perf tools: Use const for variables receiving str{str,r?chr}() returns Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 07/18] perf parse-events: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 08/18] perf tools: Remove unused color_fwrite_lines Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 09/18] perf strlist: Don't write to const memory Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 10/18] perf metricgroup: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11 7:10 ` Shreenidhi Shedi [this message]
2026-05-11 7:10 ` [PATCH 6.1.y v2 12/18] perf trace-event: " Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 13/18] perf units: " Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 14/18] perf bpf: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 15/18] perf time-utils: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 16/18] perf demangle-java: " Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 17/18] perf parse-events:: Fix -Wdiscarded-qualifiers under C23 Shreenidhi Shedi
2026-05-11 7:10 ` [PATCH 6.1.y v2 18/18] perf bpf-event: Constify variables storing the result of strchr() on const tables Shreenidhi Shedi
2026-05-11 8:16 ` [PATCH 6.1.y v2 00/18] Backport fixes for -Wdiscarded-qualifiers and -Wnonnull with newer glibc Greg KH
2026-05-13 6:37 ` Shreenidhi Shedi
2026-05-13 7:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511071051.537859-12-yesshedi@gmail.com \
--to=yesshedi@gmail.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux@treblig.org \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.