All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <achender@kernel.org>
To: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
	kuba@kernel.org, horms@kernel.org, linux-rdma@vger.kernel.org,
	achender@kernel.org, linux-kselftest@vger.kernel.org,
	shuah@kernel.org
Subject: [PATCH net-next v1 1/9] selftests: rds: Capitalize ret global in test.py
Date: Mon, 11 May 2026 00:23:08 -0700	[thread overview]
Message-ID: <20260511072316.1174045-2-achender@kernel.org> (raw)
In-Reply-To: <20260511072316.1174045-1-achender@kernel.org>

Global variables outside of functions should be capitalized to avoid
pylint complaints.  Fix this before refactoring to avoid complaints
later.

Signed-off-by: Allison Henderson <achender@kernel.org>
---
 tools/testing/selftests/net/rds/test.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py
index 6db606779231..d78c00226e7b 100755
--- a/tools/testing/selftests/net/rds/test.py
+++ b/tools/testing/selftests/net/rds/test.py
@@ -291,29 +291,29 @@ stop_pcaps()
 
 # We're done sending and receiving stuff, now let's check if what
 # we received is what we sent.
-ret = 0
+RC = 0
 for (sender, receiver), send_hash in send_hashes.items():
     recv_hash = recv_hashes.get((sender, receiver))
 
     if recv_hash is None:
         ksft_pr("FAIL: No data received")
-        ret = 1
+        RC = 1
         break
 
     if send_hash.hexdigest() != recv_hash.hexdigest():
         ksft_pr("FAIL: Send/recv mismatch")
         ksft_pr("hash expected:", send_hash.hexdigest())
         ksft_pr("hash received:", recv_hash.hexdigest())
-        ret = 1
+        RC = 1
         break
 
     ksft_pr(f"{sender}/{receiver}: ok")
 
-if ret == 0:
+if RC == 0:
     ksft_pr("Success")
     print("ok 1 rds selftest")
 else:
     print("not ok 1 rds selftest")
 
-ksft_pr(f"Totals: pass:{1-ret} fail:{ret} skip:0")
-sys.exit(ret)
+ksft_pr(f"Totals: pass:{1-RC} fail:{RC} skip:0")
+sys.exit(RC)
-- 
2.25.1


  reply	other threads:[~2026-05-11  7:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:23 [PATCH net-next v1 0/9] selftests: rds: Add ROCE support to rds selftests Allison Henderson
2026-05-11  7:23 ` Allison Henderson [this message]
2026-05-11  7:23 ` [PATCH net-next v1 2/9] selftests: rds: Add helper function setup_tcp() in test.py Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 3/9] selftests: rds: Add helper function check_info() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 4/9] selftests: rds: Add helper function send_burst() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 5/9] selftests: rds: Add helper function recv_burst() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 6/9] selftests: rds: Add helper function verify_hashes() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 7/9] selftests: rds: Add helper function snd_rcv_packets() " Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 8/9] selftests: rds: Add ROCE support to test.py Allison Henderson
2026-05-11  7:23 ` [PATCH net-next v1 9/9] selftests: rds: Add ROCE support to run.sh Allison Henderson
2026-05-13  1:42 ` [PATCH net-next v1 0/9] selftests: rds: Add ROCE support to rds selftests Jakub Kicinski
2026-05-13  1:54   ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511072316.1174045-2-achender@kernel.org \
    --to=achender@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.