From: Christoph Hellwig <hch@lst.de>
To: Anders Larsen <al@alarsen.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>,
Luis de Bethencourt <luisbg@kernel.org>,
Salah Triki <salah.triki@gmail.com>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
Dave Kleikamp <shaggy@kernel.org>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Bob Copeland <me@bobcopeland.com>,
linux-fsdevel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev,
linux-karma-devel@lists.sourceforge.net
Subject: Re: [PATCH 03/10] qnx4: handle set_blocksize failures
Date: Mon, 11 May 2026 09:45:56 +0200 [thread overview]
Message-ID: <20260511074556.GA28186@lst.de> (raw)
In-Reply-To: <12893675.O9o76ZdvQC@oscar>
On Mon, May 11, 2026 at 09:42:49AM +0200, Anders Larsen wrote:
> Hi,
>
> On 2026-05-11 09:16 Christoph Hellwig wrote:
> > qnx4 uses buffer_heads, which don't handle block size > PAGE_SIZE well.
>
> qnx4fs uses a fixed block size of 512 bytes, so this will never happen.
>
> > - sb_set_blocksize(s, QNX4_BLOCK_SIZE);
> > + if (!sb_set_blocksize(s, QNX4_BLOCK_SIZE))
> > + return -EINVAL;
>
> QNX4_BLOCK_SIZE is a constant (512)...
Yes, which means that sb_set_blocksize fails when the device has an LBA
size larger than 512 bytes, and this failure should be handled.
next prev parent reply other threads:[~2026-05-11 7:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 7:16 fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christoph Hellwig
2026-05-11 7:16 ` [PATCH 01/10] bfs: handle set_blocksize failures Christoph Hellwig
2026-05-11 16:10 ` Jan Kara
2026-05-11 7:16 ` [PATCH 02/10] hpfs: " Christoph Hellwig
2026-05-11 7:16 ` [PATCH 03/10] qnx4: " Christoph Hellwig
2026-05-11 7:42 ` Anders Larsen
2026-05-11 7:45 ` Christoph Hellwig [this message]
2026-05-11 8:20 ` Anders Larsen
2026-05-11 7:16 ` [PATCH 04/10] jfs: " Christoph Hellwig
2026-05-11 7:16 ` [PATCH 05/10] befs: " Christoph Hellwig
2026-05-11 7:16 ` [PATCH 06/10] affs: " Christoph Hellwig
2026-05-23 15:33 ` David Sterba
2026-05-11 7:16 ` [PATCH 07/10] isofs: " Christoph Hellwig
2026-05-11 16:10 ` Jan Kara
2026-05-11 7:16 ` [PATCH 08/10] minix: " Christoph Hellwig
2026-05-11 16:08 ` Jan Kara
2026-05-12 6:08 ` Christoph Hellwig
2026-05-12 12:13 ` Christian Brauner
2026-05-11 7:16 ` [PATCH 09/10] ntfs3: " Christoph Hellwig
2026-05-11 7:16 ` [PATCH 10/10] omfs: " Christoph Hellwig
2026-05-11 13:40 ` Christian Brauner
2026-05-11 13:41 ` fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511074556.GA28186@lst.de \
--to=hch@lst.de \
--cc=aivazian.tigran@gmail.com \
--cc=al@alarsen.net \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=luisbg@kernel.org \
--cc=me@bobcopeland.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=ntfs3@lists.linux.dev \
--cc=salah.triki@gmail.com \
--cc=shaggy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.