From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C613A4F26 for ; Mon, 11 May 2026 13:09:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504951; cv=none; b=MB2E/e3+InIVeAbZ6Na+3qmAaH9m+IworpsOz5rmJoot4YwIQPDF/qY7yRGRYQ7CXCNJLgO4FTOXNjt8CObLIFcQL8FPz6eAFBChD/f3Ifq+qN0Anz/fxdmXqU+17OateES/Jb3UD+FFqEPbxfXotDI+dCffuOfYfcUGCpzQ5qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778504951; c=relaxed/simple; bh=XWcofE4V55bO53CBZvGR/Dgd1hsKDCRCvsY5qQXKI6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RMEQGVJISqsfs7/XnPEXoJEcSb35qOI5qMEcXdSOYOjvHZ+xd3XnWrJMrjuqKR24fpgI4zK7Xy7TCNlFlfDUiwJZIvFGpFehOQ0KKhvl/UpgVXlV5fwnOUgBUP/4MIPINHGUUpuSZsvm58++I7AINzC0sLiSJBbZtONpaHcvGEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TWAJ8vpW; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TWAJ8vpW" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-835386ff122so3894364b3a.3 for ; Mon, 11 May 2026 06:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778504949; x=1779109749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7S/zPzUjbACO6a/KbjkmptJ3lgVoecfug/I/z6PqGMU=; b=TWAJ8vpWYiFYFzWheCTOsjzsAYjIZZNrZFgYC0CdYY23gnLauxXOeVD1csGWPcx4Gq ZEWnRk+Gb0ZiDm9AIfLPxE0zDz8b1HqWWsMEmGio8tZD3b1QADazeqgt5eXeAFD2jJml gES/7LIjxw+45eDP7lp03lT5hhP1VOb0gupRcNAxvhKq3ULQoKTlmt+EOM+ncTKoo4OG tFQtmPr3WTJ9MWERRahHBiwreQMBkSCTxz48MSXT5ddF3xehw6yDAEs9qDySsuueV38c opuYNePM7z+/xNscM3mZkkkcu2rwudTkDFApRtIz66SQs5fqXzqqaaEXhgfoTUGDkmTK EW3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778504949; x=1779109749; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7S/zPzUjbACO6a/KbjkmptJ3lgVoecfug/I/z6PqGMU=; b=pyWaQon165N0R8f8RtwZh48HwyTwdL3+D/zQXj5EiFajGdD0nOH5uDZ6coz1whVX91 DFx6PnGu8evKUZxL3znSpVyQUdt4mAntAH1fidNkAGnem7Syjp51Uxf20N6/1HmlmduO j+puReyNkzfG+oCDnlXvjuwGcTxBK43NmuV44HVrA0RVFSq34vj2ERIc4xYxGOI0vVBe wxqYnJ3m6vKHC1DSX9qO/BOmPnKtcr+9NkUf55qtlVLjQmgKHbBdEJcFJbmIvWNXgbYs lefc9qcsiGzh5RHLmfLJuB07p86PHrmTNLwYefYaKCSsJopqy5iIed+dSF8PzGZ/X4Vx ggoQ== X-Forwarded-Encrypted: i=1; AFNElJ9RJRothr0CQVBKU03eXg7GvPZHKg7CyIJVXjKR8HYv5hiMQjxcQ/UXmxjogopXqezghbkzq/WVzjfy1ts=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp5BGE/fn9Tvqi9YHFDoOX9+hVqISCz7Gl7vaezSeY4r3Cii/h 4qsl0NMcSaqlOEeEFTeEsP2Lo0oRnoFzaWKMp25PBALhcjnJLWdeNPkm X-Gm-Gg: Acq92OEVxqgsrQU5+ToUuwWEzsGjNcV6bz6Ex5DiZJs4TTv/yIiW+onWt0E+oYm9sKY LjuSzW61D2XsIz5Lczct3kUPjgMBqf0XoNQsKy7anQL5lUXNkH6PSOLShcIk9OcfX/iGF79zpri dBNwo35k8HbhdgrEZS9UZ0mNRCuXYe7e/3zii8o02QymMBx4Oz3Z8xsE6nIthzyREM7Y3xeVELn vnKy0rm2nka25iXIrn8HbvuFHm0R+85RMwAzCFqh9JksbvE8P/qrZXSqe0iozmKZuw+2mivH4oS deyEUjO//DjApP2pjOyhdhMLTg5aYFEhTDa29Bs5AJoF6KQB5VPkVRDPUnM9xhBWlz5Op68Tb4t uEs8KcYMXWT6LfdnwjXTB4R5HR2e/NXh0JjFAiV15vUexJaeVfAWSxRcyWG15sMVQ0Pug6y2Nlg WjPMAiMCkDd2DXb0dzIglL X-Received: by 2002:a05:6a00:4503:b0:82f:8b20:9165 with SMTP id d2e1a72fcca58-83a5ea3ffafmr24130826b3a.44.1778504949428; Mon, 11 May 2026 06:09:09 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965c30ddasm25641973b3a.21.2026.05.11.06.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 06:09:09 -0700 (PDT) From: Guangshuo Li To: "Md. Haris Iqbal" , Jack Wang , Jason Gunthorpe , Leon Romanovsky , Vaishali Thakkar , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH v2] RDMA/rtrs: Fix use-after-free in path files cleanup Date: Mon, 11 May 2026 21:08:04 +0800 Message-ID: <20260511130804.773204-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Once kobject_put() is called on srv_path->kobj, the release callback may be triggered and srv_path may be freed. Therefore, srv_path must not be used after kobject_put(&srv_path->kobj). Both rtrs_srv_create_path_files() and rtrs_srv_destroy_path_files() currently call rtrs_srv_destroy_once_sysfs_root_folders(srv_path) after kobject_put(&srv_path->kobj). Although the call site only passes srv_path as an argument, rtrs_srv_destroy_once_sysfs_root_folders() dereferences it internally to access srv_path->srv. If kobject_put() has already freed srv_path, this results in a use-after-free. Move rtrs_srv_destroy_once_sysfs_root_folders() before kobject_put(), so srv_path remains valid while the helper accesses it. This issue was found by a static analysis tool I am developing. Fixes: ae4c81644e91 ("RDMA/rtrs-srv: Rename rtrs_srv_sess to rtrs_srv_path") Acked-by: Md Haris Iqbal Signed-off-by: Guangshuo Li --- v2: - Clarify that the use-after-free happens inside rtrs_srv_destroy_once_sysfs_root_folders(), which dereferences srv_path after kobject_put() may have freed it. - No code changes. drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c index 51727c7d710c..c9ba9d2d0eb3 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c @@ -295,8 +295,8 @@ int rtrs_srv_create_path_files(struct rtrs_srv_path *srv_path) put_kobj: kobject_del(&srv_path->kobj); destroy_root: - kobject_put(&srv_path->kobj); rtrs_srv_destroy_once_sysfs_root_folders(srv_path); + kobject_put(&srv_path->kobj); return err; } @@ -312,8 +312,8 @@ void rtrs_srv_destroy_path_files(struct rtrs_srv_path *srv_path) if (srv_path->kobj.state_in_sysfs) { sysfs_remove_group(&srv_path->kobj, &rtrs_srv_path_attr_group); - kobject_put(&srv_path->kobj); rtrs_srv_destroy_once_sysfs_root_folders(srv_path); + kobject_put(&srv_path->kobj); } } -- 2.43.0