From: Greg KH <gregkh@linuxfoundation.org>
To: Denis Arzubov <denisarzubov8@gmail.com>
Cc: linux-staging@lists.linux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix const pointer declaration
Date: Mon, 11 May 2026 09:57:43 +0200 [thread overview]
Message-ID: <2026051136-bribe-retention-76a3@gregkh> (raw)
In-Reply-To: <20260504223628.60428-1-denisarzubov8@gmail.com>
On Tue, May 05, 2026 at 01:36:27AM +0300, Denis Arzubov wrote:
> Make g_fbmode array pointer const to follow kernel coding style.
> This resolves the checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
>
> Signed-off-by: Denis Arzubov <denisarzubov8@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index fadba95850be..8fc0d1c66991 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.43.0
>
Please always test-build your changes :(
prev parent reply other threads:[~2026-05-11 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 22:36 [PATCH] staging: sm750fb: Fix const pointer declaration Denis Arzubov
2026-05-11 7:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051136-bribe-retention-76a3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=denisarzubov8@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.