From: sashiko-bot@kernel.org
To: "Iker Pedrosa" <ikerpedrosam@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v9 1/8] dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching
Date: Tue, 12 May 2026 01:01:46 +0000 [thread overview]
Message-ID: <20260512010147.3AFD3C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260511-orangepi-sd-card-uhs-v9-1-ae48c0b2b2cf@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message documents the UHS pinctrl state as `state_uhs`, but the YAML schema defines and enforces `uhs`.
--
commit 9737b985fb2ae6422b14964720c1ea756e86a00f
Author: Iker Pedrosa <ikerpedrosam@gmail.com>
dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching
This commit documents pinctrl properties to support voltage-dependent pin
configuration switching for UHS-I SD card modes.
> Add optional pinctrl-names property with two states:
> - "default": For 3.3V operation with standard drive strength
> - "state_uhs": For 1.8V operation with optimized drive strength
Is state_uhs the intended name for this pinctrl state? The YAML schema
introduced in this patch restricts the second item in pinctrl-names to uhs,
and uses uhs in both the examples and property descriptions.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-orangepi-sd-card-uhs-v9-0-ae48c0b2b2cf@gmail.com?part=1
next prev parent reply other threads:[~2026-05-12 1:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 8:53 [PATCH v9 0/8] riscv: spacemit: enable SD card support with UHS modes for OrangePi RV2 Iker Pedrosa
2026-05-11 8:53 ` Iker Pedrosa
2026-05-11 8:53 ` [PATCH v9 1/8] dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching Iker Pedrosa
2026-05-11 8:53 ` Iker Pedrosa
2026-05-12 1:01 ` sashiko-bot [this message]
2026-05-11 8:53 ` [PATCH v9 2/8] mmc: sdhci-of-k1: enable essential clock infrastructure for SD operation Iker Pedrosa
2026-05-11 8:53 ` Iker Pedrosa
2026-05-12 1:13 ` sashiko-bot
2026-05-11 8:53 ` [PATCH v9 3/8] mmc: sdhci-of-k1: add regulator and pinctrl voltage switching support Iker Pedrosa
2026-05-11 8:53 ` Iker Pedrosa
2026-05-12 2:01 ` sashiko-bot
2026-05-11 8:53 ` [PATCH v9 4/8] mmc: sdhci-of-k1: add comprehensive SDR tuning support Iker Pedrosa
2026-05-11 8:53 ` Iker Pedrosa
2026-05-11 8:54 ` [PATCH v9 5/8] riscv: dts: spacemit: k1: add SD card controller and pinctrl support Iker Pedrosa
2026-05-11 8:54 ` Iker Pedrosa
2026-05-12 2:47 ` sashiko-bot
2026-05-11 8:54 ` [PATCH v9 6/8] riscv: dts: spacemit: k1-orangepi-rv2: add SD card support with UHS modes Iker Pedrosa
2026-05-11 8:54 ` Iker Pedrosa
2026-05-12 3:20 ` sashiko-bot
2026-05-11 8:54 ` [PATCH v9 7/8] riscv: dts: spacemit: k1-bananapi-f3: " Iker Pedrosa
2026-05-11 8:54 ` Iker Pedrosa
2026-05-11 16:55 ` Aurelien Jarno
2026-05-11 16:55 ` Aurelien Jarno
2026-05-12 3:32 ` sashiko-bot
2026-05-12 5:43 ` Yixun Lan
2026-05-12 5:43 ` Yixun Lan
2026-05-12 17:03 ` Aurelien Jarno
2026-05-12 17:03 ` Aurelien Jarno
2026-05-12 22:49 ` Yixun Lan
2026-05-12 22:49 ` Yixun Lan
2026-05-11 8:54 ` [PATCH v9 8/8] riscv: dts: spacemit: k1-musepi-pro: " Iker Pedrosa
2026-05-11 8:54 ` Iker Pedrosa
2026-05-11 11:43 ` Andre Heider
2026-05-11 11:43 ` Andre Heider
2026-05-12 3:48 ` sashiko-bot
2026-05-12 5:20 ` Yixun Lan
2026-05-12 5:20 ` Yixun Lan
2026-05-11 15:40 ` [PATCH v9 0/8] riscv: spacemit: enable SD card support with UHS modes for OrangePi RV2 Ulf Hansson
2026-05-11 15:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512010147.3AFD3C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ikerpedrosam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.