All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: pratmal@google.com
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, shuah@kernel.org, yosry@kernel.org,
	david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com,
	vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] selftests/mm: use pattern matching in .gitignore
Date: Mon, 11 May 2026 18:01:48 -0700	[thread overview]
Message-ID: <20260512010148.1175-1-sj@kernel.org> (raw)
In-Reply-To: <20260511173411.267628-1-pratmal@google.com>

On Mon, 11 May 2026 17:34:09 +0000 pratmal@google.com wrote:

> From: Pratyush Mallick <pratmal@google.com>
> 
> The current selftests/mm/.gitignore hardcodes each generated test binary
> by name, which requires manual updates every time a new test is added.
> 
> This series switches to a pattern-matching approach (similar to KVM
> selftests), ignoring everything by default and allowing specific source
> extensions. To accommodate this without tracking generated headers,
> local_config.h is renamed to local_config.h_gen.
> 
> Changelog since v2:
> - Split the changes into two separate patches (header rename and
>   .gitignore update)
> - Added Suggested-by for David Hildenbrand for the header rename approach.
> - Dropped David's and Yosry's Reviewed-by tags.
> - Kept Lorenzo Stoakes's Reviewed-by and added Mike Rapoport's Acked-by.
> 
> Changelog since v1 (RFC):
> - Renamed local_config.h to local_config.h_gen to avoid conflict with !*.h.
> - Updated Makefile, check_config.sh, and affected .c files for the rename.
> - Removed *.mod.c as it was unnecessary.

Adding previous revision links together [1] would be helpful for people who
willing to see details of previous discussions.

> 
> Pratyush Mallick (2):
>   selftests/mm: use pattern matching in .gitignore
>   selftests/mm: rename local_config.h to local_config.h_gen

So, after applying the first patch, we may show local_config.h unexpectedly
shown on 'git status' output?  Maybe too trivial thing, but I'm wondering if we
already considered doing the renaming first.

[1] https://docs.kernel.org/process/submitting-patches.html#commentary


Thanks,
SJ

[...]

      parent reply	other threads:[~2026-05-12  1:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 17:34 [PATCH v3 0/2] selftests/mm: use pattern matching in .gitignore pratmal
2026-05-11 17:34 ` [PATCH v3 1/2] " pratmal
2026-05-11 17:34 ` [PATCH v3 2/2] selftests/mm: rename local_config.h to local_config.h_gen pratmal
2026-05-12  1:01 ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512010148.1175-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pratmal@google.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.