All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Natália Salvino André" <natalia.andre@ime.usp.br>
To: andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org,
	jikos@kernel.org, nuno.sa@analog.com,
	srinivas.pandruvada@linux.intel.com
Cc: "Natália Salvino André" <natalia.andre@ime.usp.br>,
	"Pietro Di Consolo Gregorio" <pietro.gregorio@usp.br>,
	linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH v3 6/6] iio: pressure: HID: hid-sensor-press: Refactor channel initialization
Date: Mon, 11 May 2026 22:16:22 -0300	[thread overview]
Message-ID: <20260512012302.20883-7-natalia.andre@ime.usp.br> (raw)
In-Reply-To: <20260512012302.20883-1-natalia.andre@ime.usp.br>

Replace the local press_adjust_channel_bit_mask() function with a
compound literal for scan_type initialization to improve code
readability.

Signed-off-by: Natália Salvino André <natalia.andre@ime.usp.br>
Co-developed-by: Pietro Di Consolo Gregorio <pietro.gregorio@usp.br>
Signed-off-by: Pietro Di Consolo Gregorio <pietro.gregorio@usp.br>
---
 drivers/iio/pressure/hid-sensor-press.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c
index 5f1d6abda3e4..a039b99d9851 100644
--- a/drivers/iio/pressure/hid-sensor-press.c
+++ b/drivers/iio/pressure/hid-sensor-press.c
@@ -3,6 +3,7 @@
  * HID Sensors Driver
  * Copyright (c) 2014, Intel Corporation.
  */
+#include <linux/bitops.h>
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
@@ -53,17 +54,6 @@ static const struct iio_chan_spec press_channels[] = {
 
 };
 
-/* Adjust channel real bits based on report descriptor */
-static void press_adjust_channel_bit_mask(struct iio_chan_spec *channels,
-					int channel, int size)
-{
-	channels[channel].scan_type.sign = 's';
-	/* Real storage bits will change based on the report desc. */
-	channels[channel].scan_type.realbits = size * 8;
-	/* Maximum size of a sample to capture is u32 */
-	channels[channel].scan_type.storagebits = sizeof(u32) * 8;
-}
-
 /* Channel read_raw handler */
 static int press_read_raw(struct iio_dev *indio_dev,
 			      struct iio_chan_spec const *chan,
@@ -225,8 +215,11 @@ static int press_parse_report(struct platform_device *pdev,
 			&st->press_attr);
 	if (ret < 0)
 		return ret;
-	press_adjust_channel_bit_mask(channels, CHANNEL_SCAN_INDEX_PRESSURE,
-					st->press_attr.size);
+	channels[CHANNEL_SCAN_INDEX_PRESSURE].scan_type = (struct iio_scan_type) {
+		.format = 's',
+		.realbits = BYTES_TO_BITS(st->press_attr.size),
+		.storagebits = BITS_PER_TYPE(u32),
+	};
 
 	dev_dbg(&pdev->dev, "press %x:%x\n", st->press_attr.index,
 			st->press_attr.report_id);
-- 
2.51.0


  parent reply	other threads:[~2026-05-12  1:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  1:16 [PATCH v3 0/6] iio: hid-sensor: standardize scan_type initialization Natália Salvino André
2026-05-12  1:16 ` [PATCH v3 1/6] iio: accel: HID: hid-sensor-accel-3d: Refactor channel initialization Natália Salvino André
2026-05-13  2:21   ` sashiko-bot
2026-05-12  1:16 ` [PATCH v3 2/6] iio: gyro: HID: hid-sensor-gyro-3d: " Natália Salvino André
2026-05-13  2:50   ` sashiko-bot
2026-05-15 16:48   ` srinivas pandruvada
2026-05-16 11:44     ` Jonathan Cameron
2026-05-12  1:16 ` [PATCH v3 3/6] iio: light: HID: hid-sensor-als: " Natália Salvino André
2026-05-13  3:00   ` sashiko-bot
2026-05-12  1:16 ` [PATCH v3 4/6] iio: light: HID: hid-sensor-prox: " Natália Salvino André
2026-05-13  3:10   ` sashiko-bot
2026-05-12  1:16 ` [PATCH v3 5/6] iio: magnetometer: HID: hid-sensor-magn-3d: " Natália Salvino André
2026-05-13  3:19   ` sashiko-bot
2026-05-12  1:16 ` Natália Salvino André [this message]
2026-05-13  3:30   ` [PATCH v3 6/6] iio: pressure: HID: hid-sensor-press: " sashiko-bot
2026-05-12 14:42 ` [PATCH v3 0/6] iio: hid-sensor: standardize scan_type initialization Jonathan Cameron
2026-05-12 20:21   ` Andy Shevchenko
2026-05-12 14:48 ` Jonathan Cameron
2026-05-13  3:27   ` Zhang, Lixu
2026-05-14  2:44   ` Zhang, Lixu
2026-05-15 16:50 ` srinivas pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512012302.20883-7-natalia.andre@ime.usp.br \
    --to=natalia.andre@ime.usp.br \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pietro.gregorio@usp.br \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.