From: sashiko-bot@kernel.org
To: "Kathiravan Thirumoorthy" <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: ipq5210: add the download mode support
Date: Tue, 12 May 2026 02:17:38 +0000 [thread overview]
Message-ID: <20260512021738.F06ABC2BCF5@smtp.kernel.org> (raw)
In-Reply-To: <20260511-ipq5210_dload_support-v1-1-5609c6b8330e@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a new compatible string `qcom,tcsr-ipq5210` for the TCSR node in `ipq5210.dtsi` without adding it to the corresponding device tree binding schema (`Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml`).
--
commit 9435d5db06195f6fe5ee397b1257dbedf5ed5ea2
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
arm64: dts: qcom: ipq5210: add the download mode support
Enable support for download mode to collect RAM dumps in case
of system crash, facilitating post mortem analysis.
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab246..cd587eef00180 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
[ ... ]
> @@ -160,6 +161,11 @@ tcsr_mutex: hwlock@1905000 {
> #hwlock-cells = <1>;
> };
>
> + tcsr: syscon@1937000 {
> + compatible = "qcom,tcsr-ipq5210", "syscon";
Should this new compatible string also be added to the corresponding device
tree binding schema?
It appears that "qcom,tcsr-ipq5210" is not documented in
Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml, which might cause
dtbs_check validation to emit warnings about an undocumented compatible
string.
> + reg = <0x0 0x01937000 0x0 0x2b000>;
> + };
> +
> qupv3: geniqup@1ac0000 {
> compatible = "qcom,geni-se-qup";
> reg = <0x0 0x01ac0000 0x0 0x2000>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-ipq5210_dload_support-v1-1-5609c6b8330e@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-05-12 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 11:01 [PATCH] arm64: dts: qcom: ipq5210: add the download mode support Kathiravan Thirumoorthy
2026-05-12 2:17 ` sashiko-bot [this message]
2026-05-15 8:23 ` Krzysztof Kozlowski
2026-05-15 9:16 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512021738.F06ABC2BCF5@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.