From: sashiko-bot@kernel.org
To: "Harrison Vanderbyl" <harrison.vanderbyl@gmail.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v1 5/8] hid: Pen battery quirk for Surface Pro 12in
Date: Tue, 12 May 2026 06:07:54 +0000 [thread overview]
Message-ID: <20260512060755.18AD0C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <2702fbde567457ea0835ba12cc29421590e688aa.1778498477.git.harrison.vanderbyl@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Macro value alignment uses spaces instead of a tab.
--
commit c48c3082a15452ea3cc6ed81c88834aa52ab9d60
Author: Harrison Vanderbyl <harrison.vanderbyl@gmail.com>
hid: Pen battery quirk for Surface Pro 12in
This commit adds a quirk to ignore the battery on the Surface Pro 12in
pen, which uses Bluetooth for battery reporting instead of I2C. This
prevents a phantom battery or device hang.
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -459,6 +459,7 @@
> #define USB_DEVICE_ID_HP_X2 0x074d
> #define USB_DEVICE_ID_HP_X2_10_COVER 0x0755
> #define I2C_DEVICE_ID_CHROMEBOOK_TROGDOR_POMPOM 0x2F81
> +#define I2C_DEVICE_ID_SURFACE_PRO_12IN 0x4376
This isn't a bug, but it looks like spaces were used here instead of a tab
to align the macro value.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1778498477.git.harrison.vanderbyl@gmail.com?part=5
next prev parent reply other threads:[~2026-05-12 6:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:40 [PATCH v1 0/8] Add support for Microsoft Surface Pro 12in 1st Edition (Snapdragon) Harrison Vanderbyl
2026-05-11 14:40 ` [PATCH v1 1/8] dt-bindings: arm: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-11 14:40 ` [PATCH v1 2/8] dt-bindings: crypto: Add x1e80100 inline crypto Harrison Vanderbyl
2026-05-11 14:40 ` [PATCH v1 3/8] platform/surface: SAM: Add support for Surface Pro 12in Harrison Vanderbyl
2026-05-11 14:40 ` [PATCH v1 4/8] firmware: qcom: scm: Allow QSEECOM on " Harrison Vanderbyl
2026-05-12 18:44 ` Dmitry Baryshkov
2026-05-11 14:40 ` [PATCH v1 5/8] hid: Pen battery quirk for " Harrison Vanderbyl
2026-05-12 6:07 ` sashiko-bot [this message]
2026-05-12 16:15 ` Jiri Kosina
2026-05-11 14:40 ` [PATCH v1 6/8] drm/panel-edp: Add panel " Harrison Vanderbyl
2026-05-11 15:13 ` Doug Anderson
2026-05-11 19:38 ` Dmitry Baryshkov
2026-05-11 14:40 ` [PATCH v1 7/8] arm64: dts: qcom: hamoa: Add inline crypto for UFS Harrison Vanderbyl
2026-05-12 17:54 ` Dmitry Baryshkov
2026-05-11 14:40 ` [PATCH v1 8/8] arm64: dts: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-12 18:44 ` Dmitry Baryshkov
2026-05-12 21:23 ` sashiko-bot
2026-05-13 15:09 ` Konrad Dybcio
2026-05-13 19:08 ` (subset) [PATCH v1 0/8] Add support for Microsoft Surface Pro 12in 1st Edition (Snapdragon) Bjorn Andersson
2026-05-15 5:41 ` [PATCH v2 0/7] Add support for the Microsoft Surface Pro 12in 1st Edition (Snapdragon), Harrison Vanderbyl
2026-05-15 5:41 ` [PATCH v2 1/7] dt-bindings: arm: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 7:03 ` Krzysztof Kozlowski
2026-05-15 5:41 ` [PATCH v2 2/7] dt-bindings: crypto: Add x1e80100 inline crypto Harrison Vanderbyl
2026-05-15 7:04 ` Krzysztof Kozlowski
2026-05-15 5:41 ` [PATCH v2 3/7] platform/surface: SAM: Add support for Surface Pro 12in Harrison Vanderbyl
2026-05-15 6:02 ` sashiko-bot
2026-05-15 5:41 ` [PATCH v2 4/7] hid: Pen battery quirk " Harrison Vanderbyl
2026-05-15 6:12 ` sashiko-bot
2026-05-15 5:41 ` [PATCH v2 5/7] drm/panel-edp: Add panel " Harrison Vanderbyl
2026-05-15 5:41 ` [PATCH v2 6/7] arm64: dts: qcom: hamoa: Add inline crypto for UFS Harrison Vanderbyl
2026-05-15 6:24 ` sashiko-bot
2026-05-15 5:41 ` [PATCH v2 7/7] arm64: dts: qcom: Add Microsoft Surface Pro 12in Harrison Vanderbyl
2026-05-15 6:56 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512060755.18AD0C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=harrison.vanderbyl@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.