All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] OpenPOSIX: Allow 0 return value when detaching or joining joined thread
Date: Tue, 12 May 2026 08:08:15 +0000	[thread overview]
Message-ID: <20260512080815.3976-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260509082649.8533-1-wegao@suse.com>

Hi Wei,

On Sat, 09 May 2026 08:26:47 +0000, Wei Gao wrote:
> OpenPOSIX: Allow 0 return value when detaching or joining joined thread

> These are caused by glibc commit 5da15b15adab661c80e373b6af89be0b5fa5b3ad
> ("nptl: Do not use pthread set_tid_address as state synchronization (BZ #19951)").

The motivation is clear and the fix looks correct — accepting 0 in addition
to ESRCH matches the new glibc behavior.

> The new glibc logic removed the explicit validation of thread handles that
> previously returned ESRCH:

The commit message is missing a Signed-off-by: tag. Please add:

  Signed-off-by: Wei Gao <wegao@suse.com>

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25721673051

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-05-12  8:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09  8:26 [LTP] [PATCH v1] OpenPOSIX: Allow 0 return value when detaching or joining joined thread Wei Gao via ltp
2026-05-12  8:08 ` linuxtestproject.agent [this message]
2026-05-12  8:18   ` [LTP] " Andrea Cervesato via ltp
2026-05-12  9:21     ` Wei Gao via ltp
2026-05-12  9:30       ` Andrea Cervesato via ltp
2026-05-12  8:18 ` [LTP] [PATCH v1] " Andrea Cervesato via ltp
2026-05-12  9:31 ` Andrea Cervesato via ltp
2026-05-12 11:10 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512080815.3976-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.