All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aadeshveer Singh <aadeshveer07@gmail.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, farosas@suse.de,
	Aadeshveer Singh <aadeshveer07@gmail.com>
Subject: [PATCH] [migration] Replace current_migration with migrate_get_current()
Date: Tue, 12 May 2026 15:30:00 +0530	[thread overview]
Message-ID: <20260512095959.736285-2-aadeshveer07@gmail.com> (raw)

Replaces the direct accesses to global variable `current_migration`
with `migrate_get_current()` to ensure safety and
consistency across systems.

Note: Following this only direct access to `current_migration` will be
* `migrate_get_current()` itself
* `migration_object_init()` initializes `current_migration`
* `migration_is_running()`, as there might be a case where this function
  is called by a thread before object initialization

Signed-off-by: Aadeshveer Singh <aadeshveer07@gmail.com>
---
 migration/migration.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index ecc69dc4d2..f3a96b1949 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -321,7 +321,7 @@ void migration_object_init(void)
 
     current_incoming->exit_on_error = INMIGRATE_DEFAULT_EXIT_ON_ERROR;
 
-    migration_object_check(current_migration, &error_fatal);
+    migration_object_check(migrate_get_current(), &error_fatal);
 
     ram_mig_init();
     dirty_bitmap_mig_init();
@@ -385,7 +385,7 @@ void migration_shutdown(void)
      * stop the migration using this structure
      */
     migration_cancel();
-    object_unref(OBJECT(current_migration));
+    object_unref(OBJECT(migrate_get_current()));
 
     /*
      * Cancel outgoing migration of dirty bitmaps. It should
@@ -1029,7 +1029,7 @@ bool migration_is_running(void)
 
 static bool migration_is_active(void)
 {
-    MigrationState *s = current_migration;
+    MigrationState *s = migrate_get_current();
 
     return (s->state == MIGRATION_STATUS_ACTIVE ||
             s->state == MIGRATION_STATUS_POSTCOPY_DEVICE ||
@@ -1634,7 +1634,7 @@ bool migration_in_bg_snapshot(void)
 
 bool migration_thread_is_self(void)
 {
-    MigrationState *s = current_migration;
+    MigrationState *s = migrate_get_current();
 
     return qemu_thread_is_self(&s->thread);
 }
@@ -3062,7 +3062,7 @@ static MigThrError postcopy_pause(MigrationState *s)
 
 void migration_file_set_error(int ret, Error *err)
 {
-    MigrationState *s = current_migration;
+    MigrationState *s = migrate_get_current();
 
     WITH_QEMU_LOCK_GUARD(&s->qemu_file_lock) {
         if (s->to_dst_file) {
-- 
2.54.0



             reply	other threads:[~2026-05-12 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:00 Aadeshveer Singh [this message]
2026-05-12 15:28 ` [PATCH] [migration] Replace current_migration with migrate_get_current() Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512095959.736285-2-aadeshveer07@gmail.com \
    --to=aadeshveer07@gmail.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.