All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: broonie@kernel.org, vkoul@kernel.org
Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev,
	yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com,
	oder_chiou@realtek.com, jack.yu@realtek.com,
	shumingf@realtek.com, niranjan.hy@ti.com, shenghao-ding@ti.com,
	kevin-lu@ti.com, baojun.xu@ti.com, sen@ti.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: [PATCH v3 15/18] ASoC: rt1318: Use new SoundWire enumeration helper
Date: Tue, 12 May 2026 11:13:45 +0100	[thread overview]
Message-ID: <20260512101348.1138044-16-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20260512101348.1138044-1-ckeepax@opensource.cirrus.com>

Update the driver to use the new core helper that waits for the device
to enumerate on SoundWire and be initialised by the SoundWire core.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

No changes since v2.

 sound/soc/codecs/rt1318-sdw.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c
index d28f1afe68f18..51bd11b92a554 100644
--- a/sound/soc/codecs/rt1318-sdw.c
+++ b/sound/soc/codecs/rt1318-sdw.c
@@ -821,23 +821,15 @@ static int rt1318_dev_resume(struct device *dev)
 {
 	struct sdw_slave *slave = dev_to_sdw_dev(dev);
 	struct rt1318_sdw_priv *rt1318 = dev_get_drvdata(dev);
-	unsigned long time;
+	int ret;
 
 	if (!rt1318->first_hw_init)
 		return 0;
 
-	if (!slave->unattach_request)
-		goto regmap_sync;
-
-	time = wait_for_completion_timeout(&slave->initialization_complete,
-				msecs_to_jiffies(RT1318_PROBE_TIMEOUT));
-	if (!time) {
-		dev_err(&slave->dev, "%s: Initialization not complete, timed out\n", __func__);
-		return -ETIMEDOUT;
-	}
+	ret = sdw_slave_wait_for_init(slave, RT1318_PROBE_TIMEOUT);
+	if (ret)
+		return ret;
 
-regmap_sync:
-	slave->unattach_request = 0;
 	regcache_cache_only(rt1318->regmap, false);
 	regcache_sync(rt1318->regmap);
 
-- 
2.47.3


  parent reply	other threads:[~2026-05-12 10:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:13 [PATCH v3 00/18] Add a new SoundWire enumeration helper Charles Keepax
2026-05-12 10:13 ` [PATCH v3 01/18] soundwire: Add a helper function to wait for device initialisation Charles Keepax
2026-05-12 10:13 ` [PATCH v3 02/18] ASoC: cs35l56: Use new SoundWire enumeration helper Charles Keepax
2026-05-12 10:13 ` [PATCH v3 03/18] ASoC: cs42l42: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 04/18] ASoC: max98363: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 05/18] ASoC: max98373: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 06/18] ASoC: rt700: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 07/18] ASoC: rt711: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 08/18] ASoC: rt712: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 09/18] ASoC: rt715: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 10/18] ASoc: rt721: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 11/18] ASoC: rt722: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 12/18] ASoC: rt1017: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 13/18] ASoC: rt1308: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 14/18] ASoC: rt1316: " Charles Keepax
2026-05-12 10:13 ` Charles Keepax [this message]
2026-05-12 10:13 ` [PATCH v3 16/18] ASoC: rt1320: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 17/18] ASoC: rt5682: " Charles Keepax
2026-05-12 10:13 ` [PATCH v3 18/18] ASoC: tas2783: " Charles Keepax
2026-05-12 11:13 ` [PATCH v3 00/18] Add a " Holalu Yogendra, Niranjan
2026-05-12 11:50   ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512101348.1138044-16-ckeepax@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=jack.yu@realtek.com \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=niranjan.hy@ti.com \
    --cc=oder_chiou@realtek.com \
    --cc=patches@opensource.cirrus.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=shumingf@realtek.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.