All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, edwards@nvidia.com,
	kees@kernel.org, parav@nvidia.com, mbloch@nvidia.com,
	yishaih@nvidia.com, lirongqing@baidu.com,
	huangjunxian6@hisilicon.com, liuy22@mails.tsinghua.edu.cn,
	jmoroni@google.com
Subject: Re: [PATCH rdma-next v2 1/2] RDMA/uverbs: expose CoCo DMA bounce requirement to userspace
Date: Tue, 12 May 2026 16:03:29 +0300	[thread overview]
Message-ID: <20260512130329.GU15586@unreal> (raw)
In-Reply-To: <20260506111447.2697789-2-jiri@resnulli.us>

On Wed, May 06, 2026 at 01:14:46PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> In CoCo guests, device DMA to regular userspace memory does not work
> because the DMA mapping layer redirects all mappings through swiotlb
> bounce buffers. Since RDMA devices access registered memory directly
> without CPU involvement, there is no opportunity for swiotlb to
> synchronize between the bounce buffer and the original pages.
> 
> Expose this condition to userspace as IB_UVERBS_DEVICE_CC_DMA_BOUNCE
> in device_cap_flags_exi.
> 
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> ---
>  drivers/infiniband/core/device.c     | 6 ++++++
>  drivers/infiniband/core/uverbs_cmd.c | 2 ++
>  include/rdma/ib_verbs.h              | 3 +++
>  include/uapi/rdma/ib_user_verbs.h    | 2 ++
>  4 files changed, 13 insertions(+)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index b89efaaa81ec..ad3da92c9318 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -42,6 +42,8 @@
>  #include <linux/security.h>
>  #include <linux/notifier.h>
>  #include <linux/hashtable.h>
> +#include <linux/cc_platform.h>
> +#include <linux/swiotlb.h>
>  #include <rdma/rdma_netlink.h>
>  #include <rdma/ib_addr.h>
>  #include <rdma/ib_cache.h>
> @@ -1419,6 +1421,10 @@ int ib_register_device(struct ib_device *device, const char *name,
>  	 */
>  	WARN_ON(dma_device && !dma_device->dma_parms);
>  	device->dma_device = dma_device;
> +	if (dma_device &&
> +	    cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) &&
> +	    is_swiotlb_force_bounce(dma_device))

It is the wrong place. When I worked on my DMA series, I tried something
similar (a call into SWIOTLB) to notify users that RDMA would not work.

The general feedback was that this is a layering violation, and that any
knowledge of SWIOTLB (and its API) should not leak out of the DMA API.

You shouldn't call to is_swiotlb_force_bounce() here.

Thanks

  reply	other threads:[~2026-05-12 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 11:14 [PATCH rdma-next v2 0/2] RDMA: detect and handle CoCo DMA bounce buffering Jiri Pirko
2026-05-06 11:14 ` [PATCH rdma-next v2 1/2] RDMA/uverbs: expose CoCo DMA bounce requirement to userspace Jiri Pirko
2026-05-12 13:03   ` Leon Romanovsky [this message]
2026-05-12 14:03     ` Jiri Pirko
2026-05-12 14:05       ` Jason Gunthorpe
2026-05-12 14:08         ` Jiri Pirko
2026-05-12 14:34           ` Jason Gunthorpe
2026-05-12 18:30             ` Jiri Pirko
2026-05-06 11:14 ` [PATCH rdma-next v2 2/2] RDMA/umem: block plain userspace memory registration under CoCo bounce Jiri Pirko
2026-05-12 13:05   ` Leon Romanovsky
2026-05-12 14:04     ` Jiri Pirko
2026-05-14 16:25       ` Leon Romanovsky
2026-05-15  6:13         ` Jiri Pirko
2026-05-06 12:52 ` [PATCH rdma-next v2 0/2] RDMA: detect and handle CoCo DMA bounce buffering Jacob Moroni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512130329.GU15586@unreal \
    --to=leon@kernel.org \
    --cc=edwards@nvidia.com \
    --cc=huangjunxian6@hisilicon.com \
    --cc=jgg@ziepe.ca \
    --cc=jiri@resnulli.us \
    --cc=jmoroni@google.com \
    --cc=kees@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=liuy22@mails.tsinghua.edu.cn \
    --cc=mbloch@nvidia.com \
    --cc=parav@nvidia.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.