Re: [PATCH 1/3] platform_defs.h: fix __counted_by_ptr annotation

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, May 12, 2026 at 01:48:25PM +0200, Andrey Albershteyn wrote:
> On 2026-05-07 15:11:27, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > The kernel userspace headers for Linux 7.0 provide the __counted_by_ptr
> > macro, so we shouldn't define it separately on those platforms:
> > 
> >   In file included from radix-tree.c:11:
> >   ../include/platform_defs.h:334:9: error: "__counted_by_ptr" redefined [-Werror]
> >     334 | #define __counted_by_ptr(member)
> >         |         ^~~~~~~~~~~~~~~~
> >   In file included from /usr/include/linux/posix_types.h:5,
> >                    from /usr/include/linux/types.h:9,
> >                    from /usr/include/linux/sched/types.h:5,
> >                    from /usr/include/x86_64-linux-gnu/bits/sched.h:63,
> >                    from /usr/include/sched.h:43,
> >                    from /usr/include/pthread.h:22,
> >                    from ../include/platform_defs.h:19:
> >   /usr/include/linux/stddef.h:73:9: note: this is the location of the previous definition
> >      73 | #define __counted_by_ptr(m)
> >         |         ^~~~~~~~~~~~~~~~
> > 
> > Do the customary ifndef wrapper thing.
> > 
> > Cc: <linux-xfs@vger.kernel.org> # v7.0.0
> > Fixes: df91bc3bdc9b81 ("xfs: annotate struct xfs_attr_list_context with __counted_by_ptr")
> > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> ops, I haven't tried with new headers

To be fair, I hadn't either -- I hadn't tried with the kernel 7.0 uapi
headers until after you'd pushed the release.  Oops.

> do you have -Werror enabled by default?

Yep.

> Looks good to me
> Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>

Thanks!

--D

> -- 
> - Andrey
> 
>