From: Lukas Straub <lukasstraub2@web.de>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mark Kanda <mark.kanda@oracle.com>,
Ben Chaney <bchaney@akamai.com>
Subject: Re: [PATCH v1 14/15] tests/qtest/migration: Stop passing URI into migrate_start
Date: Tue, 12 May 2026 16:27:02 +0200 [thread overview]
Message-ID: <20260512162702.3468d827@penguin> (raw)
In-Reply-To: <20260505160915.25558-15-farosas@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
On Tue, 5 May 2026 13:09:13 -0300
Fabiano Rosas <farosas@suse.de> wrote:
> Don't allow changing the default -incoming URI via migrate_start. The
> default is now -incoming defer. If a test really needs to alter this
> (such as with CPR), the target_opts variable is still available to
> change the command line.
>
> (aside from the larger goal of using defer, this change is a step
> towards allowing migrate_start() to be invoked only once for all
> tests)
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/migration/colo-tests.c | 2 +-
> tests/qtest/migration/cpr-tests.c | 6 +++---
> tests/qtest/migration/file-tests.c | 3 +--
> tests/qtest/migration/framework.c | 17 ++++++++---------
> tests/qtest/migration/framework.h | 5 ++---
> tests/qtest/migration/misc-tests.c | 10 +++++-----
> tests/qtest/migration/precopy-tests.c | 12 ++++++------
> 7 files changed, 26 insertions(+), 29 deletions(-)
For migration/colo-tests.c:
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Lukas Straub <lukasstraub2@web.de>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-05-12 14:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 16:08 [PATCH v1 00/15] tests/qtest/migration: Always defer Fabiano Rosas
2026-05-05 16:09 ` [PATCH v1 01/15] tests/qtest/migration: Move cpr transfer logic into cpr-tests.c Fabiano Rosas
2026-05-19 20:43 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 02/15] tests/qtest/migration: Make file-tests defer by default Fabiano Rosas
2026-05-19 20:45 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 03/15] tests/qtest/migration: Set file URI " Fabiano Rosas
2026-05-19 20:46 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 04/15] tests/qtest/migration: Group unix migration tests Fabiano Rosas
2026-05-19 20:47 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 05/15] tests/qtest/migration: Use precopy_unix_common for ignore-shared test Fabiano Rosas
2026-05-20 16:06 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 06/15] tests/qtest/migration: Use a default TCP URI for precopy Fabiano Rosas
2026-05-20 16:07 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 07/15] tests/qtest/migration: Defer by default in precopy_common Fabiano Rosas
2026-05-12 14:27 ` Lukas Straub
2026-05-20 16:14 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 08/15] tests/qtest/migration: Set compression method in compression-tests Fabiano Rosas
2026-05-20 16:15 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 09/15] tests/qtest/migration: Remove multifd compression hook Fabiano Rosas
2026-05-20 16:16 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 10/15] tests/qtest/migration: Use defer for all tests Fabiano Rosas
2026-05-20 16:20 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 11/15] tests/qtest/migration: Use defer for cpr-tests Fabiano Rosas
2026-05-20 17:37 ` Peter Xu
2026-05-22 13:23 ` Fabiano Rosas
2026-05-05 16:09 ` [PATCH v1 12/15] tests/qtest/migration: Use defer for auto-converge Fabiano Rosas
2026-05-20 17:37 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 13/15] tests/qtest/migration: Use defer in dirty_limit test Fabiano Rosas
2026-05-20 17:37 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 14/15] tests/qtest/migration: Stop passing URI into migrate_start Fabiano Rosas
2026-05-12 14:27 ` Lukas Straub [this message]
2026-05-20 18:21 ` Peter Xu
2026-05-05 16:09 ` [PATCH v1 15/15] tests/qtest/migration: Unify URIs Fabiano Rosas
2026-05-12 14:26 ` Lukas Straub
2026-05-20 18:36 ` Peter Xu
2026-05-05 16:25 ` [PATCH v1 00/15] tests/qtest/migration: Always defer Peter Xu
2026-05-05 19:06 ` Fabiano Rosas
2026-05-19 20:34 ` Peter Xu
2026-05-20 18:56 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512162702.3468d827@penguin \
--to=lukasstraub2@web.de \
--cc=bchaney@akamai.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.