From: sashiko-bot@kernel.org
To: "Namhyung Kim" <namhyung@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 5/7] perf build: Add make check-headers target
Date: Tue, 12 May 2026 21:54:00 +0000 [thread overview]
Message-ID: <20260512215401.562E9C2BCF6@smtp.kernel.org> (raw)
In-Reply-To: <20260510202346.49853-6-namhyung@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale documentation in tools/include/uapi/README regarding the check-headers.sh mechanism.
--
commit a1e286351cec4f0692528127c5b9fe5ec64aafc6
Author: Namhyung Kim <namhyung@kernel.org>
perf build: Add make check-headers target
This commit removes the check-headers.sh script from the default perf
build process to reduce noise. It instead introduces a separate manual
check-headers make target that can be run occasionally.
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index cee19c923c060..585637fc934fe 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -285,7 +285,6 @@ goals := $(filter-out all sub-make, $(MAKECMDGOALS))
> $(goals) all: sub-make
>
> sub-make: fixdep
> - @./check-headers.sh
This isn't a bug, but does this change leave the documentation in
tools/include/uapi/README out of date?
The README currently states that check-headers.sh is "part of the tools/
build process" and describes a "software-enforced copy-on-write
mechanism... driven by non-fatal warnings on the tooling side build".
Since the script is now a manual make target rather than running
automatically during the default build, should the documentation be updated
to reflect this change?
> $(Q)$(MAKE) FIXDEP_BUILT=1 -f Makefile.perf $(goals)
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260510202346.49853-1-namhyung@kernel.org?part=5
next prev parent reply other threads:[~2026-05-12 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 20:23 [PATCH v3 0/7] perf build: Update kernel headers Namhyung Kim
2026-05-10 20:23 ` [PATCH v3 1/7] perf trace: Sync linux/socket.h with the kernel source Namhyung Kim
2026-05-10 20:23 ` [PATCH v3 2/7] perf trace: Sync uapi/linux/fs.h " Namhyung Kim
2026-05-10 20:23 ` [PATCH v3 3/7] perf trace: Sync uapi/linux/mount.h " Namhyung Kim
2026-05-10 20:23 ` [PATCH v3 4/7] perf trace: Sync uapi/linux/sched.h " Namhyung Kim
2026-05-12 21:53 ` sashiko-bot
2026-05-10 20:23 ` [PATCH v3 5/7] perf build: Add make check-headers target Namhyung Kim
2026-05-12 21:54 ` sashiko-bot [this message]
2026-05-10 20:23 ` [PATCH v3 6/7] perf trace: Add beautifier script for fsmount flags Namhyung Kim
2026-05-12 21:54 ` sashiko-bot
2026-05-10 20:23 ` [PATCH v3 7/7] perf trace: Update beautifier script for clone flags Namhyung Kim
2026-05-12 21:54 ` sashiko-bot
2026-05-11 18:22 ` [PATCH v3 0/7] perf build: Update kernel headers Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512215401.562E9C2BCF6@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.