Re: [PATCH] dt-bindings: Consolidate "sram" property definition

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The global `sram-consumer.yaml` schema causes `dtbs_check` validation failures due to a namespace collision with standard `sram` child nodes.
--

commit b3fd675e204900532756fc42297dea0b1787d10f
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: Consolidate "sram" property definition

The "sram" property has become a de facto standard property, so create a
common schema for it and drop all the duplicated definitions.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/sram/sram-consumer.yaml b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> new file mode 100644
> index 0000000000000..f00087bd2879b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sram/sram-consumer.yaml
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sram/sram-consumer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SRAM Consumers
> +
> +maintainers:
> +  - Rob Herring <robh@kernel.org>
> +
> +select: true
> +
> +properties:
> +  sram:
> +    description:
> +      Phandles to one or more reserved on-chip SRAM regions. The regions
> +      should be defined as child nodes of the respective SRAM node, and
> +      should be defined as per the generic bindings in,
> +      Documentation/devicetree/bindings/sram/sram.yaml
> +    $ref: /schemas/types.yaml#/definitions/phandle-array

Will this cause dtbs_check validation failures due to a namespace collision
with standard sram child nodes?

Because select: true makes this apply globally, it intercepts the "sram"
key for all nodes. In dt-schema, properties and child nodes share the exact
same namespace.

A child node named sram without a unit-address (which is permitted by
sram.yaml and exists in device trees like arch/powerpc/boot/dts/ebony.dts)
is represented in the YAML output as a JSON object assigned to the "sram"
key of its parent.

When dt-validate evaluates the parent node, this global schema will attempt
to validate the child node object against the phandle-array constraints,
triggering a schema validation error because an object is not an array.

Is there a way to limit the selection so it doesn't match these child
nodes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511165942.2774868-1-robh@kernel.org?part=1