From: David Ahern <dsahern@kernel.org>
To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, David Ahern <dahern@nvidia.com>
Subject: [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD
Date: Wed, 13 May 2026 10:50:24 -0600 [thread overview]
Message-ID: <20260513165028.33171-1-dsahern@kernel.org> (raw)
From: David Ahern <dahern@nvidia.com>
tfcpad is a u32, but that full range is excessive for padding.
Limit it to max IP length (64k).
Signed-off-by: David Ahern <dahern@nvidia.com>
---
net/xfrm/xfrm_user.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 38a90e5ee3d9..e8c31633f4f1 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -937,8 +937,14 @@ static struct xfrm_state *xfrm_state_construct(struct net *net,
attrs[XFRMA_ALG_COMP], extack)))
goto error;
- if (attrs[XFRMA_TFCPAD])
+ if (attrs[XFRMA_TFCPAD]) {
x->tfcpad = nla_get_u32(attrs[XFRMA_TFCPAD]);
+ if (x->tfcpad > IP_MAX_MTU) {
+ NL_SET_ERR_MSG(extack, "Excessive TFC padding");
+ err = -EINVAL;
+ goto error;
+ }
+ }
xfrm_mark_get(attrs, &x->mark);
--
2.43.0
next reply other threads:[~2026-05-13 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:50 David Ahern [this message]
2026-05-16 8:02 ` [PATCH net-next] xfrm: Reject excessive values for XFRMA_TFCPAD Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513165028.33171-1-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=dahern@nvidia.com \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.