From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819152D29C8
	for <linux-kernel@vger.kernel.org>; Wed, 13 May 2026 23:52:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778716358; cv=none; b=dam3Eds780dAhyZw/n0dCT51eja4Jk8GV3otjk++FumhcKVsRGJZSaYCAu4WIcBC6B+PSMBOuuqWDo4d99c4oIu1Vhd4kH9nfVPt//UTreIv+lUxX7wzGaTdIkwj3qq3HGLUWUlyDCooYh0Qn+QXT5OZYCdyTHnnaRHUHWJQLs0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778716358; c=relaxed/simple;
	bh=6sjfGyRvi2eyrx8ASbutXAd3bxNg93phmnH214iLao8=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=S+ErhT8WALAyckXJVj2ZAElJVMp9FCpyr9IGI6eXd5KcyUDGcnTUIuHOhR8fN37V6+J1uNN+VmpAAf8xqI2OWF8SEnBK9Zq28mHZCPd11jmf49JinZDYuv7+wprVhjslXy7urqS9tiavShiYMqpfKFl6Z+BoPb3AzrrsXKS4KWU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=VykzLD6v; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="VykzLD6v"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98F2FC19425;
	Wed, 13 May 2026 23:52:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1778716358;
	bh=6sjfGyRvi2eyrx8ASbutXAd3bxNg93phmnH214iLao8=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=VykzLD6vGZTyPB+I4wmNTrawtW1fSQUopJDi2sG9lGqrGU2MAgjqcW8hN5C0shGqc
	 uDGU94017WjkHwd5oLWWsmIy6R80obFc08HQq/OwEV7/biX/elxCrdcyPSHTH+F5DV
	 ik/b89B0vIl7Lc2/Tqha9ppQRnHI40UWQN6iw2xA=
Date: Wed, 13 May 2026 16:52:37 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>, Kees Cook <kees@kernel.org>, Kusaram
 Devineni <kusaram@devineni.in>, Peter Zijlstra <peterz@infradead.org>,
 Thomas Gleixner <tglx@kernel.org>, Will Drewry <wad@chromium.org>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call
 __send_signal_locked()
Message-Id: <20260513165237.b7a2cad23da85997609f31b0@linux-foundation.org>
In-Reply-To: <afYGeHSWkLzXDlvC@redhat.com>
References: <afYGeHSWkLzXDlvC@redhat.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov <oleg@redhat.com> wrote:

> force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> info is always valid and has_si_pid_and_uid(info) should never be true.
> Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> overlaps with .si_addr/si_call_addr/etc.

Thanks.  AI review said things:
	https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@redhat.com