From: Jakub Kicinski <kuba@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
horms@kernel.org, pabeni@redhat.com, edumazet@google.com,
dsahern@kernel.org, davem@davemloft.net,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH 2/3 net-next v4] ipv4: handle devconf post-set actions on netlink updates
Date: Wed, 13 May 2026 19:30:39 -0700 [thread overview]
Message-ID: <20260513193039.7dd435df@kernel.org> (raw)
In-Reply-To: <20260510081528.5257-2-fmancera@suse.de>
On Sun, 10 May 2026 10:15:27 +0200 Fernando Fernandez Mancera wrote:
> - nla_for_each_nested(a, tb[IFLA_INET_CONF], rem)
> - ipv4_devconf_set(in_dev, nla_type(a), nla_get_u32(a));
> + nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) {
> + int old_value = ipv4_devconf_get(in_dev, nla_type(a));
> + int new_value = nla_get_u32(a);
Hm, what checks if nla_type(a) is in range?
next prev parent reply other threads:[~2026-05-14 2:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 8:15 [PATCH 1/3 net-next v4] ipv4: centralize devconf sysctl handling Fernando Fernandez Mancera
2026-05-10 8:15 ` [PATCH 2/3 net-next v4] ipv4: handle devconf post-set actions on netlink updates Fernando Fernandez Mancera
2026-05-14 2:30 ` Jakub Kicinski [this message]
2026-05-14 9:16 ` Fernando Fernandez Mancera
2026-05-10 8:15 ` [PATCH 3/3 net-next v4] selftests: net: add test for IPv4 devconf netlink notifications Fernando Fernandez Mancera
2026-05-14 2:35 ` Jakub Kicinski
2026-05-14 9:42 ` Fernando Fernandez Mancera
2026-05-14 23:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513193039.7dd435df@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.