Re: [PATCH v3 1/6] mfd: dt-bindings: mt6397: Add regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The LDO regulator `va09` is documented as being powered by two different, independent supply pins in the DT bindings.
--

commit 91d90b748e83ee395e8498f7028062225c991970
Author: Chen-Yu Tsai <wenst@chromium.org>

mfd: dt-bindings: mt6397: Add regulator supplies

On the MT6397 family each buck regulator has a separate supply, and LDOs are
split into various groups with independent supplies. This commit adds 
descriptions for all of the MT6359 supplies.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 05c121b0cb3d8..9e60536779819 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
[ ... ]
> @@ -225,12 +225,62 @@ properties:
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        "compatible":
> +          contains:
> +            const: mediatek,mt6359
> +    then:
> +      properties:
> +        vsys-ldo1-supply:
> +          description: Supply for LDOs vcn33_[12], vio28, vfe28, vibr
> +        vsys-ldo2-supply:
> +          description: Supply for LDOs va09, vaux18, vbif28, vxo22, vrfck, vrfck_1,
> +            vemc, vsim1, vsim2, vusb

Is it expected for the va09 LDO regulator to be supplied by two different
pins? It is listed here under vsys-ldo2-supply.

[ ... ]
> +        vs2-ldo1-supply:
> +          description:
> +            Supply for LDOs vsram_proc1, vsram_proc2, vsram_others, vsram_md
> +        vs2-ldo2-supply:
> +          description: Supply for LDOs va09, va12, vcn13, vrf12

It is also listed here under vs2-ldo2-supply.

Subsequent patches in the series (specifically commit regulator: mt6359:
Add regulator supply names) clarify that ldo_va09 is exclusively supplied
by vs2-ldo2. Does this mean the reference to va09 should be removed from
vsys-ldo2-supply?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512085358.1693208-1-wenst@chromium.org?part=1