From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
Date: Wed, 13 May 2026 21:39:19 +0000 [thread overview]
Message-ID: <20260513213920.66F83C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260512-eliza-adsp-usb-v3-3-6420282841c2@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typo, referencing the PMIC as 'PM7750BA' instead of 'PM7550BA'.
--
commit dc49b5fa41df22268334cfe92de38c6b4f58dc80
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support
This commit enables USB and ADSP support on the Eliza MTP. It describes the
USB Type-C port and the eUSB2 repeater, and enables the corresponding USB
controller and PHYs.
> The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are
> routed through an eUSB2 repeater provided by the PM7750BA PMIC.
This isn't a bug, but is there a typo in the commit message? It references
the PM7750BA PMIC, but the code changes include pm7550ba-eliza.dtsi and
configure the pm7550ba_eusb2_repeater node.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-eliza-adsp-usb-v3-0-6420282841c2@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-05-13 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:26 [PATCH v3 0/3] arm64: dts: qcom: eliza: Add ADSP and USB support Abel Vesa
2026-05-12 12:26 ` [PATCH v3 1/3] arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes Abel Vesa
2026-05-12 18:54 ` Dmitry Baryshkov
2026-05-13 9:19 ` Konrad Dybcio
2026-05-13 21:12 ` sashiko-bot
2026-05-12 12:26 ` [PATCH v3 2/3] arm64: dts: qcom: Add Eliza-specific PM7750BA dtsi Abel Vesa
2026-05-12 18:54 ` Dmitry Baryshkov
2026-05-13 1:33 ` Alexander Koskovich
2026-05-13 6:15 ` Abel Vesa
2026-05-13 21:28 ` sashiko-bot
2026-05-12 12:26 ` [PATCH v3 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support Abel Vesa
2026-05-12 22:04 ` Dmitry Baryshkov
2026-05-13 6:10 ` Abel Vesa
2026-05-13 9:44 ` Dmitry Baryshkov
2026-05-13 9:58 ` Abel Vesa
2026-05-13 10:04 ` Dmitry Baryshkov
2026-05-13 21:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513213920.66F83C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.