Re: [PATCH] hwmon: (nct7802) Add time step attributes for tweaking responsiveness

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kstrtoul is called with base 0 for a time interval, allowing unintended octal parsing.
--

commit 3cecff14f185e191b2b2e66dc9e9e9cb80c25244
Author: Ronan Dalton <ronan.dalton@alliedtelesis.co.nz>

hwmon: (nct7802) Add time step attributes for tweaking responsiveness

This commit adds sysfs attributes to configure the step up and step down
time intervals for the Smart Fan mode on the nct7802 chip. The user-facing
values are specified in milliseconds and clamped to valid ranges.

> diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
> index 8c9351da12c6e..f30123fd908cd 100644
> --- a/drivers/hwmon/nct7802.c
> +++ b/drivers/hwmon/nct7802.c
[ ... ]
> +static ssize_t step_time_store(struct device *dev,
> +			       struct device_attribute *attr, const char *buf,
> +			       size_t count, bool step_up)
> +{
> +	struct nct7802_data *data = dev_get_drvdata(dev);
> +	unsigned long val;
> +	unsigned int reg;
> +	int ret;
> +
> +	ret = kstrtoul(buf, 0, &val);

Does this allow unintended octal parsing?

Using base 0 means that a zero-padded string written from a userspace script
(e.g., echo 0150 > step_up_time) will be parsed as an octal number rather
than decimal.

Should this use base 10 instead to prevent surprising behavior and match
other standard sysfs attribute parsers in this driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512041607.988078-2-ronan.dalton@alliedtelesis.co.nz?part=1