From: Conor Dooley <conor@kernel.org>
To: webgeek1234@gmail.com
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Teguh Sobirin <teguh@sobir.in>
Subject: Re: [PATCH v2 2/2] drm/panel: Add panel driver for Chipone ICNA35XX based panels
Date: Thu, 14 May 2026 19:05:46 +0100 [thread overview]
Message-ID: <20260514-sphere-overstep-e564bf7ca609@spud> (raw)
In-Reply-To: <20260514-icna35xx-v2-2-45acd1dfa566@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Thu, May 14, 2026 at 12:24:50PM -0500, Aaron Kling via B4 Relay wrote:
> +static const struct of_device_id icna35xx_of_match[] = {
> + { .compatible = "ayaneo,pocketds-panel-top", .data = &odin2portal_desc },
> + { .compatible = "ayntec,odin2portal-panel", .data = &odin2portal_desc },
> + { .compatible = "ayntec,odin3-panel", .data = &thor_top_desc },
> + { .compatible = "ayntec,thor-panel-top", .data = &thor_top_desc },
This looks like you could be using the fallback compatibles instead of
matching on the panel's. Why aren't you?
> + { /* sentinel */ }
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-05-14 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 17:24 [PATCH v2 0/2] drm/panel: Add panel driver for Chipone ICNA35XX based panels Aaron Kling via B4 Relay
2026-05-14 17:24 ` Aaron Kling
2026-05-14 17:24 ` [PATCH v2 1/2] dt-bindings: display: panel: Add Chipone ICNA 35xx OLED driver bindings Aaron Kling via B4 Relay
2026-05-14 17:24 ` Aaron Kling
2026-05-14 18:06 ` Conor Dooley
2026-05-14 18:20 ` Aaron Kling
2026-05-14 18:23 ` Conor Dooley
2026-05-14 18:27 ` Aaron Kling
2026-05-14 20:20 ` sashiko-bot
2026-05-14 17:24 ` [PATCH v2 2/2] drm/panel: Add panel driver for Chipone ICNA35XX based panels Aaron Kling via B4 Relay
2026-05-14 17:24 ` Aaron Kling
2026-05-14 18:05 ` Conor Dooley [this message]
2026-05-14 18:24 ` Aaron Kling
2026-05-14 18:53 ` Conor Dooley
2026-05-14 21:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514-sphere-overstep-e564bf7ca609@spud \
--to=conor@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=teguh@sobir.in \
--cc=tzimmermann@suse.de \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.