All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Frank Li" <Frank.Li@nxp.com>
Cc: imx@lists.linux.dev, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	Frank.Li@kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: net: dsa: Convert lan9303.txt to yaml format
Date: Thu, 14 May 2026 00:10:25 +0000	[thread overview]
Message-ID: <20260514001025.8D4FBC19425@smtp.kernel.org> (raw)
In-Reply-To: <20260512214704.1084890-1-Frank.Li@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unresolved phandles in YAML examples will cause `dt_binding_check` to fail.
--

commit ff1d6b54c66febb1ac2492f6699ba1d476db3541
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: net: dsa: Convert lan9303.txt to yaml format

This commit converts the SMSC/MicroChip LAN9303 device tree binding from
text to YAML format. It also renames switch-phy to switch in the example
to resolve warnings during device tree checks.

> diff --git a/Documentation/devicetree/bindings/net/dsa/smsc,lan9303.yaml b/Documentation/devicetree/bindings/net/dsa/smsc,lan9303.yaml
> new file mode 100644
> index 0000000000000..42f8473538a07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/smsc,lan9303.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    /* I2C managed mode */
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        switch@a {
> +            compatible = "smsc,lan9303-i2c";
> +            reg = <0xa>;
> +            reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;

Will this example fail dt_binding_check? The &gpio7 phandle is referenced
here, but there does not appear to be a corresponding gpio7 label defined
within the scope of the example.

> +            reset-duration = <200>;
> +
> +            ports {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +
> +                port@0 {
> +                    reg = <0>;
> +                    label = "cpu";
> +                    ethernet = <&master>;

Similarly, the &master phandle is used here but is not defined. When the
example is compiled into a standalone DTS file during dt_binding_check,
does this result in a reference to non-existent node or label error from
dtc? 

Defining dummy nodes for these labels within the examples might be necessary
to allow the schema to pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512214704.1084890-1-Frank.Li@nxp.com?part=1

  reply	other threads:[~2026-05-14  0:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 21:47 [PATCH 1/1] dt-bindings: net: dsa: Convert lan9303.txt to yaml format Frank Li
2026-05-14  0:10 ` sashiko-bot [this message]
2026-05-14 20:28 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514001025.8D4FBC19425@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.