Re: [PATCH v3 4/5] hwmon: (pmbus/adm1266) replace probe-time RTC seed with rtc_class device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing Kconfig dependency on RTC_CLASS causing potential build failures.
--

commit f54ef3c53db957606d5afd59cb615359c244ece4
Author: Abdurrahman Hussain <abdurrahman@nexthop.ai>

hwmon: (pmbus/adm1266) replace probe-time RTC seed with rtc_class device

This commit drops the probe-time seed and adm1266_set_rtc() entirely. It adds
an rtc_class device whose read_time and set_time callbacks read and write the
SET_RTC frame to expose the time stamp policy properly.

> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 080e7dbd0c069..05b31bb08f38c 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c

[ ... ]

> @@ -517,21 +517,73 @@ static int adm1266_config_nvmem(struct adm1266_data *data)

[ ... ]

> +static int adm1266_register_rtc(struct adm1266_data *data)
> +{
> +	struct rtc_device *rtc;
> +
> +	rtc = devm_rtc_allocate_device(&data->client->dev);

Could this introduce a build regression if CONFIG_RTC_CLASS is disabled?

The patch unconditionally adds calls to RTC subsystem functions like
devm_rtc_allocate_device() and devm_rtc_register_device(). These functions
are implemented in the RTC core, which is governed by CONFIG_RTC_CLASS.

There are no fallback stubs in linux/rtc.h for these allocation functions
when the subsystem is disabled. Does CONFIG_SENSORS_ADM1266 need a dependency
on RTC_CLASS in drivers/hwmon/pmbus/Kconfig to prevent unresolved external
symbols during linking?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512-adm1266-v3-0-a81a479b0bb0@nexthop.ai?part=4