Re: [PATCH 6.6.y] mm/damon/reclaim: detect and use fresh enabled and kdamond_pid values

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Calls to undeclared and undefined functions `damon_is_running()` and `damon_kdamond_pid()` will cause a build failure.
--

commit f496e53eab697919d0061167b54870a26d15920a
Author: SeongJae Park <sj@kernel.org>

mm/damon/reclaim: detect and use fresh enabled and kdamond_pid values

This commit modifies DAMON_RECLAIM to query the running status and kdamond PID
dynamically to avoid stale parameters.

Link: https://lore.kernel.org/20260419161003.79176-1-sj@kernel.org
Link: https://lore.kernel.org/20260419161003.79176-2-sj@kernel.org

> diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
> index 586daa2cefe4f..e264f202714eb 100644
> --- a/mm/damon/reclaim.c
> +++ b/mm/damon/reclaim.c
[ ... ]
> @@ -203,60 +194,93 @@ static int damon_reclaim_turn(bool on)
[ ... ]
> +static bool damon_reclaim_enabled(void)
> +{
> +	if (!ctx)
> +		return false;
> +	return damon_is_running(ctx);

Will this cause a build failure? It appears damon_is_running() isn't declared
in include/linux/damon.h or defined anywhere in the tree.

> +}
[ ... ]
> +static int damon_reclaim_kdamond_pid_load(char *buffer,
> +		const struct kernel_param *kp)
> +{
> +	int kdamond_pid = -1;
> +
> +	if (ctx) {
> +		kdamond_pid = damon_kdamond_pid(ctx);

Will this also fail to compile? Similar to above, damon_kdamond_pid() doesn't
seem to be defined. Is this missing a dependency or an incomplete backport?

> +		if (kdamond_pid < 0)
> +			kdamond_pid = -1;
> +	}
> +	return sprintf(buffer, "%d\n", kdamond_pid);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513045858.204442-1-sj@kernel.org?part=1