Re: [PATCH 4/5] reset: reset-scmi: Log number of reset domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The format specifier `%d` is used to print an `unsigned int` in `dev_info()`.
--

commit dfa791ed52b95e32859483ac051e58c6d9c9975b
Author: Alex Tran <alex.tran@oss.qualcomm.com>

reset: reset-scmi: Log number of reset domains

This commit updates the SCMI reset driver to log the number of reset domains
discovered during probe. It saves the return value of the registration function
to conditionally print the information upon success.

> diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c
> index 4335811e0cfaa..f26fad0dc7268 100644
> --- a/drivers/reset/reset-scmi.c
> +++ b/drivers/reset/reset-scmi.c
[ ... ]
> @@ -111,7 +112,12 @@ static int scmi_reset_probe(struct scmi_device *sdev)
>  	data->rcdev.nr_resets = reset_ops->num_domains_get(ph);
>  	data->ph = ph;
>  
> -	return devm_reset_controller_register(dev, &data->rcdev);
> +	ret = devm_reset_controller_register(dev, &data->rcdev);
> +	if (ret)
> +		return ret;
> +
> +	dev_info(dev, "Initialized %d reset domains\n", data->rcdev.nr_resets);

This isn't a bug, but should this format specifier be %u instead of %d?

Looking at struct reset_controller_dev, nr_resets is defined as an unsigned
int.

> +	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-scmi-client-probe-log-v1-0-00b47b1be009@oss.qualcomm.com?part=4