Re: [PATCH v2] clocksource: move NXP timer selection to drivers/clocksource

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] `VF_TIMER_NONE` is selectable on Vybrid (`SOC_VF610`) platforms but relies on hardware that does not exist on those platforms.
--

commit 7af32213cbfafc4c689a6d3a071f0b9a62837a94
Author: Enric Balletbo i Serra <eballetb@redhat.com>

clocksource: move NXP timer selection to drivers/clocksource

This commit relocates the NXP clocksource selection from the ARM mach-imx
architecture Kconfig to the drivers/clocksource Kconfig so it can be shared
across architectures. It updates the choice block to support ARCH_S32 and
adds a None option to allow using the standard ARM Architected Timer.

> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index d1a33a231a44c..15c02d3e9dbff 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
[ ... ]
> +choice
> +	prompt "NXP clocksource for scheduler clock"
> +	depends on SOC_VF610 || ARCH_S32
> +	# Default to Global Timer for Vybrid (32-bit)
> +	default VF_USE_ARM_GLOBAL_TIMER if SOC_VF610
> +	# Default to None for S32 (64-bit)
> +	default VF_TIMER_NONE if ARCH_S32
> +
> +	config VF_USE_ARM_GLOBAL_TIMER
> +		bool "Use NXP Vybrid Global Timer"
> +		depends on ARCH_MULTI_V7 && SOC_VF610
> +		select ARM_GLOBAL_TIMER
> +		select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> +		help
> +		  Use the NXP Vybrid Global Timer as clocksource.
> +
> +	config VF_USE_PIT_TIMER
> +		bool "Use NXP PIT timer"
> +		select NXP_PIT_TIMER
> +		help
> +		  Use NXP Periodic Interrupt Timer (PIT) as clocksource.
> +
> +	config VF_TIMER_NONE
> +		bool "None (Use standard Arch Timer)"
> +		help
> +		  Do not use any specific NXP timer driver. Use the standard
> +		  ARM Architected Timer instead.

Does this allow VF_TIMER_NONE to be selected on Vybrid (SOC_VF610) platforms?

Since the choice block itself depends on SOC_VF610 || ARCH_S32, this option
is visible on Vybrid builds. If selected, it would result in a kernel
without a valid scheduler clocksource because the Vybrid SoC lacks the
standard ARM Architected Timer hardware.

Could VF_TIMER_NONE have a depends on ARCH_S32 or !SOC_VF610 restriction to
prevent creating unbootable kernels on Vybrid?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-fix-nxp-timer-v2-1-533b99c57b67@redhat.com?part=1