From: Igor Pytko <igorpetindev@gmail.com>
To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org
Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev,
Igor Pytko <igorpetindev@gmail.com>
Subject: [PATCH v3] staging: media: atomisp: fix trailing statements in input_system.c
Date: Thu, 14 May 2026 13:38:35 +0300 [thread overview]
Message-ID: <20260514103835.13732-1-igorpetindev@gmail.com> (raw)
Move return statements to a new line to improve code readability
and comply with the Linux kernel coding style.
This patch also fixes several checkpatch.pl errors regarding
trailing statements throughout the file.
Signed-off-by: Igor Pytko <igorpetindev@gmail.com>
---
.../hive_isp_css_common/host/input_system.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 9f1199c47..86c9d7a48 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -423,7 +423,8 @@ static input_system_err_t input_system_configure_channel(
return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
}
- if (error != INPUT_SYSTEM_ERR_NO_ERROR) return error;
+ if (error != INPUT_SYSTEM_ERR_NO_ERROR)
+ return error;
// Input switch channel configurations must be combined in united config.
config.input_switch_cfg.hsync_data_reg[channel.source_cfg.csi_cfg.csi_port * 2]
=
@@ -1094,13 +1095,15 @@ static input_system_err_t input_system_configure_channel_sensor(
status = set_source_type(&config.source_type, channel.source_type,
&config.source_type_flags);
- if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ if (status != INPUT_SYSTEM_ERR_NO_ERROR)
+ return status;
// Check for conflicts on source (implicitly on multicast, capture unit and input buffer).
status = set_csi_cfg(&config.csi_value[port], &channel.source_cfg.csi_cfg,
&config.csi_flags[port]);
- if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ if (status != INPUT_SYSTEM_ERR_NO_ERROR)
+ return status;
switch (channel.source_cfg.csi_cfg.buffering_mode) {
case INPUT_SYSTEM_FIFO_CAPTURE:
@@ -1109,7 +1112,8 @@ static input_system_err_t input_system_configure_channel_sensor(
mux = INPUT_SYSTEM_MIPI_PORT0 + port;
status = input_system_multiplexer_cfg(&config.multiplexer, mux,
&config.multiplexer_flags);
- if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ if (status != INPUT_SYSTEM_ERR_NO_ERROR)
+ return status;
config.multicast[port] = INPUT_SYSTEM_CSI_BACKEND;
// Shared resource, so it should be blocked.
@@ -1124,7 +1128,8 @@ static input_system_err_t input_system_configure_channel_sensor(
mux = INPUT_SYSTEM_ACQUISITION_UNIT;
status = input_system_multiplexer_cfg(&config.multiplexer, mux,
&config.multiplexer_flags);
- if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ if (status != INPUT_SYSTEM_ERR_NO_ERROR)
+ return status;
config.multicast[port] = INPUT_SYSTEM_INPUT_BUFFER;
// Shared resource, so it should be blocked.
@@ -1139,7 +1144,8 @@ static input_system_err_t input_system_configure_channel_sensor(
mux = INPUT_SYSTEM_ACQUISITION_UNIT;
status = input_system_multiplexer_cfg(&config.multiplexer, mux,
&config.multiplexer_flags);
- if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ if (status != INPUT_SYSTEM_ERR_NO_ERROR)
+ return status;
config.multicast[port] = INPUT_SYSTEM_INPUT_BUFFER;
// Shared resource, so it should be blocked.
--
2.43.0
reply other threads:[~2026-05-14 10:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514103835.13732-1-igorpetindev@gmail.com \
--to=igorpetindev@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.