From: Eric Biggers <ebiggers@kernel.org>
To: Linlin Zhang <linlin.zhang@oss.qualcomm.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Benjamin Marzinski <bmarzins@redhat.com>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Subject: Re: [PATCH v1 1/1] dm-inlinecrypt: initialize blk-crypto key as HW-wrapped key
Date: Thu, 14 May 2026 08:43:18 -0700 [thread overview]
Message-ID: <20260514154318.GA2266@sol> (raw)
In-Reply-To: <b0104f67-0886-4c40-89ef-bc8bb8a91689@oss.qualcomm.com>
On Thu, May 14, 2026 at 05:48:44PM +0800, Linlin Zhang wrote:
> Previously BLK_CRYPTO_KEY_TYPE_HW_WRAPPED was set for blk-crypto-profile entity
> by default, a raw key won't never passed down to ICE driver, so I replaced raw
> key type with wrapped key type directly.
>
> Now I see it already changed to query the supported type from ice. There isn't
> above concern. I'll update a new patch with both wrappedkey and raw key support
> and adding "wrappedkey" optional argument.
>
> replace "raw_key" with "key_bytes" as well.
In the upstream kernel, BLK_CRYPTO_KEY_TYPE_HW_WRAPPED was added in
v6.15 and has never been the default. Also currently only ufs-qcom and
msm-sdhci support it. ufs-exynos, ufs-mediatek, mtk-sd, ufs-sprd,
ufshcd-pci currently support raw keys only.
It should be supported, just as an opt-in thing.
- Eric
prev parent reply other threads:[~2026-05-14 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 9:52 [PATCH v1 0/1] dm-inlinecrypt: move to HW-wrapped key Linlin Zhang
2026-05-12 9:52 ` [PATCH v1 1/1] dm-inlinecrypt: initialize blk-crypto key as " Linlin Zhang
2026-05-12 18:53 ` Eric Biggers
2026-05-13 17:22 ` Eric Biggers
2026-05-14 9:48 ` Linlin Zhang
2026-05-14 15:43 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514154318.GA2266@sol \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linlin.zhang@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.