From: Jakub Kicinski <kuba@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: David Ahern <dsahern@kernel.org>, Hyunwoo Kim <imv4bel@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
steffen.klassert@secunet.com, netdev@vger.kernel.org,
stable@vger.kernel.org, mhal@rbox.co, davem@davemloft.net,
horms@kernel.org, edumazet@google.com, kerneljasonxing@gmail.com,
herbert@gondor.apana.org.au, vakzz@zellic.io, kuniyu@google.com,
jiayuan.chen@linux.dev, ben@decadent.org.uk
Subject: Re: [PATCH net v2] net: skbuff: propagate shared-frag marker through frag-transfer helpers
Date: Thu, 14 May 2026 16:38:02 -0700 [thread overview]
Message-ID: <20260514163802.1d49d7cb@kernel.org> (raw)
In-Reply-To: <agXuKbQMVTYT5Jgb@krikkit>
On Thu, 14 May 2026 17:45:45 +0200 Sabrina Dubroca wrote:
> 2026-05-14, 08:37:19 -0600, David Ahern wrote:
> > On 5/14/26 4:21 AM, Sabrina Dubroca wrote:
> > > It would close this group of vulnerabilities, but there are other
> > > parts of the networking stack that consume this flag. For those,
> > > chasing missing flag propagation is still a useful task.
> > >
> >
> > Seems like this should be an skb helper to manage the flag with really
> > good documentation on when it needs to be set, reset and propagated.
> >
> > I walked skbuff.c yesterday as well, and there are several places where
> > it is not clear if the flag needs to be propagated or not.
>
> Or maybe even something like a skb_transfer_frag that handles updating
> the frags array and copying the flag. Then we wouldn't have to chase
> functions that mess with frags[] directly and forget to also adjust
> flags.
FWIW IMHO I'm not sure this flag is worth the effort. Most of the code,
IIUC, needs to look at it for crypto. And for crypto it's cleaner to
allocate fresh pages for the output. That way the code has the same
perf whether frags were indeed shared or not. Vide tls. And non-perf
sensitive code can always cow frags.
prev parent reply other threads:[~2026-05-14 23:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 21:07 [PATCH net v2] net: skbuff: propagate shared-frag marker through frag-transfer helpers Hyunwoo Kim
2026-05-14 6:18 ` Sultan Alsawaf
2026-05-14 9:23 ` Hyunwoo Kim
2026-05-15 2:01 ` Jiayuan Chen
2026-05-15 2:34 ` Hyunwoo Kim
2026-05-14 8:04 ` Paolo Abeni
2026-05-14 9:38 ` Hyunwoo Kim
2026-05-14 10:21 ` Sabrina Dubroca
2026-05-14 14:37 ` David Ahern
2026-05-14 15:45 ` Sabrina Dubroca
2026-05-14 23:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514163802.1d49d7cb@kernel.org \
--to=kuba@kernel.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=jiayuan.chen@linux.dev \
--cc=kerneljasonxing@gmail.com \
--cc=kuniyu@google.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=vakzz@zellic.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.