Re: [PATCH 1/2] arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The SMMU is enabled at the board level rather than the SoC level, despite being an SoC-wide mandatory component.
--

commit b23c4db1700b818372c3d30cde1aa1e0dc267d27
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees

This commit enables the System Memory Management Unit (SMMU) on several
Agilex5 SoCFPGA board device trees to allow the Secure Device Manager to
correctly access peripherals.

>     Enable the SMMU on the SoCFPGA board device trees where it was
>     missing. The SoC uses a different memory-mapped base address for
>     its peripherals, which requires the System Memory Management Unit
>     (SMMU) to be active so that the Secure Device Manager (SDM) can
>     correctly access those regions through address translation.

Since the commit message indicates the SMMU is an inherent architectural
requirement of the Agilex5 SoC itself, should the SMMU be enabled by default
in the base socfpga_agilex5.dtsi file?

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index 262bb3e8e5c72..bdb608bb30ea6 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -107,6 +107,10 @@ &usb0 {
>  	disable-over-current;
>  };
>  
> +&smmu {
> +	status = "okay";
> +};
> +

Scattering the status = "okay" override across multiple board dts files
might not be necessary if the SMMU only relies on SoC-internal resources and
does not require board-specific configuration. Would it be better to remove
status = "disabled" from the smmu node in the base dtsi instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514114111.10574-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=1