Re: [PATCH 2/5] dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree example will fail `dt_binding_check` because the `reg` property uses 4 cells without a parent node specifying `#address-cells = <2>` and `#size-cells = <2>`.
--

commit 6a7e60ed22b69bbc15e77243a1b4bdb0d60396df
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: display: bridge: Document Renesas R-Car V4H DSC bindings

This commit adds the device tree binding documentation for the VESA DSC
Display Stream Compression encoder embedded in the Renesas R-Car V4H SoC.

> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml
> new file mode 100644
> index 0000000000000..91245beb67d7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsc.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r8a779g0-cpg-mssr.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/power/r8a779g0-sysc.h>
> +
> +    dsc@feb8d000 {
> +        compatible = "renesas,r8a779g0-dsc";
> +        reg = <0 0xfeb8d000 0 0x400>;

Does this introduce a regression during dt_binding_check? By default, the
schema tooling wraps examples in a root node with #address-cells = <1> and
#size-cells = <1>.

Because the reg property uses 4 cells, it will be parsed as two items, which
violates the maxItems: 1 constraint defined earlier in the binding. Wrapping
the example in a parent node that specifies #address-cells = <2> and
#size-cells = <2> should resolve this.

> +        interrupts = <GIC_SPI 559 IRQ_TYPE_LEVEL_HIGH>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-rcar-du-dsc-v1-0-d65f7a9e9841@ideasonboard.com?part=2