All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Avadhut Naik <avanaik92@gmail.com>
Subject: Re: [PATCH v4 2/2] EDAC/amd64: Include DRAM address in output
Date: Thu, 14 May 2026 15:51:31 -0400	[thread overview]
Message-ID: <20260514194904.GA11459@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260514113147.GCagWyowfypCcZ0fUo@fat_crate.local>

On Thu, May 14, 2026 at 01:31:47PM +0200, Borislav Petkov wrote:
> On Mon, Mar 16, 2026 at 08:53:24AM -0400, Yazen Ghannam wrote:
> > From: Avadhut Naik <avadhut.naik@amd.com>
> > 
> > The DRAM address of an error is used by tooling to find failure
> > patterns. This information can be used for general analysis off system.
> > And it can be used on system to take action like offline a page affected
> > by a bad row.
> > 
> > Other EDAC modules (GHES and SKX) provide this information in their
> > output. The AMD64 EDAC module was not able to provide this information,
> > because system-specific translation is needed.
> > 
> > Recent AMD systems provide a PRM handler for DRAM address translation.
> > 
> > Use this PRM handler to get the DRAM address of an error. Include this
> > in the EDAC "other_detail" field.
> > 
> > [Yazen: Reword commit message and reformat other_detail string]
> > 
> > Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> > Co-developed-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > ---
> >  drivers/edac/amd64_edac.c | 27 ++++++++++++++++++++++++++-
> >  drivers/edac/amd64_edac.h |  1 +
> >  2 files changed, 27 insertions(+), 1 deletion(-)
> 
> https://sashiko.dev/#/patchset/20260316125324.396889-1-yazen.ghannam%40amd.com
> 
> Please sanity check.
> 

This is a reasonable suggestion. Shall I send another revision?

Thanks,
Yazen

  reply	other threads:[~2026-05-14 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 12:53 [PATCH v4 0/2] Incorporate DRAM address in EDAC messages Yazen Ghannam
2026-03-16 12:53 ` [PATCH v4 1/2] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Yazen Ghannam
2026-03-16 12:53 ` [PATCH v4 2/2] EDAC/amd64: Include DRAM address in output Yazen Ghannam
2026-05-14 11:31   ` Borislav Petkov
2026-05-14 19:51     ` Yazen Ghannam [this message]
2026-05-15 10:01       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514194904.GA11459@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avanaik92@gmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.