From: sashiko-bot@kernel.org
To: dongxuyang@eswincomputing.com
Cc: robh@kernel.org, krzk+dt@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v5 3/3] reset: eswin: Add eic7700 HSP reset driver
Date: Thu, 14 May 2026 19:53:05 +0000 [thread overview]
Message-ID: <20260514195305.C4132C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260514114738.1641-1-dongxuyang@eswincomputing.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#include <linux/module.h>` for module macros.
--
commit 08281f0596a764e191cbecfd9dc12b0b51f6730f
Author: Xuyang Dong <dongxuyang@eswincomputing.com>
reset: eswin: Add eic7700 HSP reset driver
This commit adds an auxiliary driver to support the ESWIN EIC7700 high-speed
peripherals system. The reset controller is created using the auxiliary device
framework.
> diff --git a/drivers/reset/reset-eic7700-hsp.c b/drivers/reset/reset-eic7700-hsp.c
> new file mode 100644
> index 0000000000000..bdd4f5e3d7a76
> --- /dev/null
> +++ b/drivers/reset/reset-eic7700-hsp.c
> @@ -0,0 +1,112 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2026, Beijing ESWIN Computing Technology Co., Ltd..
> + * All rights reserved.
> + *
> + * ESWIN EIC7700 HSP Reset Driver
> + *
> + * Authors: Xuyang Dong <dongxuyang@eswincomputing.com>
> + */
> +
> +#include <linux/auxiliary_bus.h>
> +#include <linux/device.h>
> +#include <linux/regmap.h>
> +#include <linux/reset-controller.h>
This isn't a bug, but should this file explicitly include <linux/module.h>?
The code relies on module-specific macros such as THIS_MODULE,
MODULE_DEVICE_TABLE, MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
later in the file. Relying on an implicit include could lead to unexpected
build failures if header dependencies change in the future.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260514114212.903-1-dongxuyang@eswincomputing.com?part=3
prev parent reply other threads:[~2026-05-14 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 11:42 [PATCH v5 0/3] Add driver support for ESWIN EIC7700 HSP clock and reset generator dongxuyang
2026-05-14 11:45 ` [PATCH v5 1/3] dt-bindings: clock: Add ESWIN eic7700 " dongxuyang
2026-05-14 11:45 ` [PATCH v5 2/3] clk: eswin: Add eic7700 HSP clock driver dongxuyang
2026-05-14 19:19 ` sashiko-bot
2026-05-14 11:47 ` [PATCH v5 3/3] reset: eswin: Add eic7700 HSP reset driver dongxuyang
2026-05-14 19:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514195305.C4132C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.