From: sashiko-bot@kernel.org
To: "Swamil Jain" <s-jain1@ti.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM625-BeaglePlay
Date: Thu, 14 May 2026 23:14:42 +0000 [thread overview]
Message-ID: <20260514231442.D7206C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260514225502.2327771-1-s-jain1@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Overlay-specific pinmux configurations are placed in the base board device tree instead of the overlay DTSO.
--
commit 02fc98142af9446899da0e37e4dddce6f799d0a0
Author: Aradhya Bhatia <a-bhatia1@ti.com>
arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM625-BeaglePlay
This commit adds a device tree overlay for the LincolnTech LCD185-101CT
OLDI panel on the AM625-BeaglePlay platform. It configures the panel,
touchscreen, backlight, and display subsystem nodes in a new overlay file.
The commit also adds pin multiplexing configurations to the base board
device tree and updates the Makefile to build the new overlay.
[ ... ]
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> index c468b9c5fc09a..dc5b7f6217ad4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -510,6 +510,20 @@ AM62X_IOPAD(0x0074, PIN_OUTPUT, 1) /* (U25) GPMC0_AD14.VOUT0_DATA22 */
> AM62X_IOPAD(0x0078, PIN_OUTPUT, 1) /* (U24) GPMC0_AD15.VOUT0_DATA23 */
> >;
> };
> +
> + touchscreen_pins_default: touchscreen-default-pins {
> + pinctrl-single,pins = <
> + AM62X_IOPAD(0x01b4, PIN_OUTPUT, 7) /* (A13) SPI0_CS0.GPIO1_15 */
> + AM62X_IOPAD(0x00a0, PIN_INPUT, 7) /* (K25) GPMC0_WPn.GPIO0_39 */
> + >;
> + };
> +
> + backlight_pins_default: bl-default-pins {
> + pinctrl-single,pins = <
> + AM62X_IOPAD(0x0000, PIN_OUTPUT, 7) /* (H24) OSPI0_CLK.GPIO0_0 */
> + AM62X_IOPAD(0x01b8, PIN_OUTPUT, 2) /* (C13) SPI0_CS1.EHRPWM0_B */
> + >;
> + };
> };
>
> &mcu_pmx0 {
Should these overlay-specific pinmux configurations be placed in the base
board device tree?
Device tree overlays are typically self-contained descriptions of the add-on
hardware they enable. Adding overlay-specific pin multiplexing directly to
the base board's file adds configurations for an optional add-on into the
primary board description.
Could these pin groups be moved into a pin controller node fragment like
&main_pmx0 within the k3-am625-beagleplay-lincolntech-lcd185-panel.dtso
file instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260514225502.2327771-1-s-jain1@ti.com?part=1
prev parent reply other threads:[~2026-05-14 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 22:55 [PATCH] arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM625-BeaglePlay Swamil Jain
2026-05-14 23:14 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514231442.D7206C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.