From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ABA32EA732; Fri, 15 May 2026 00:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778804516; cv=none; b=IqJ/UveQstwjrGmhSpIablV1VEJp5C6PYaek9XjlGoA4ya9Au90IL9zS+m8FibrbB/+OYBrLoLZajB44WJoCptfFx8bSh/zSEk5RTJSRuXnuNlIdNolzObi0JxZcIWxWZrHM7NCJFlRrRrvgf7yzIJOLUIiAmmobuc6J8E89yxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778804516; c=relaxed/simple; bh=dF+pULxgBPh6nWM5sA/ztMlG6Sk2niDLCFdvGv+/nk8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VaMiqntDdNyPYVta4OwmYVJnN8ksok1DkQep8Lwc+2t0p1VuT3PBgxJB0pRXn7svIf6dl+eBdhsa5e5c4jEmUE6wKIyzk2Ic8WjzWrvdkxuY4ydQQnfr7xRNyx06e+bkX5F92bk7As8HCt7Y0XRVKG32o007zwyEK7TarxogUkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IIAr2foh; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IIAr2foh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778804515; x=1810340515; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dF+pULxgBPh6nWM5sA/ztMlG6Sk2niDLCFdvGv+/nk8=; b=IIAr2foh/8/VJzEzEjt56B5uqLl95/PQxos0BRLR8R+j6vsqfpGCSzJM 7RL8fBWYcljiBlsIyPu4YTgEByyqivny9SasEsGcvuatHMz8Xs68ACB7n BwDRWuXuRLd9ur6Qfaa86HTz23inuQKw2RxXWLRNRcPJVHJPBDIIF7V/3 wBrXrdusWS841AsSFtb/yxkEfFCY82iMBloyMTLG0ZqVIPY/zfPWALOrg JVGdPkLuXxEmeY5IVmBau4XDNrLR22ARyQ6hpWcVZaeB1Ah4J5bm7/Bt4 ehkl3ayUIxUAxwrIxsldlOfJFXc3n5G4L84wI+GF7K9WUMOZwUYGjmdTa w==; X-CSE-ConnectionGUID: qj2cZLgcTHqxUAkSqQhVzA== X-CSE-MsgGUID: eeVZ3+aHQoO06IONnnZoqg== X-IronPort-AV: E=McAfee;i="6800,10657,11786"; a="78895185" X-IronPort-AV: E=Sophos;i="6.23,235,1770624000"; d="scan'208";a="78895185" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 17:21:45 -0700 X-CSE-ConnectionGUID: 0njzKPrtQmqwdLUF4QhMwA== X-CSE-MsgGUID: A7e0Gjr6QEKHXXLnA/zdeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,235,1770624000"; d="scan'208";a="242879089" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 17:21:45 -0700 From: "David E. Box" To: y, Rajneesh Bhardwaj , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: "David E. Box" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Xi Pardee , Srinivas Pandruvada Subject: [PATCH v4 15/16] platform/x86/intel/pmc/ssram: Make PMT registration optional Date: Thu, 14 May 2026 17:21:22 -0700 Message-ID: <20260515002130.701457-16-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260515002130.701457-1-david.e.box@linux.intel.com> References: <20260515002130.701457-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The SSRAM telemetry driver extracts essential PMC device ID and power management base address information that intel_pmc_core depends on for core functionality. If PMT registration failure prevents this critical data from being available, intel_pmc_core operation would break entirely. Therefore, PMT registration failures must not block access to this data. Change the behavior to log a warning when PMT registration fails but continue with successful driver initialization, ensuring the primary telemetry data remains accessible to dependent drivers. Signed-off-by: David E. Box --- V4 - No changes V3 changes: - Dropped the standalone cleanup-pattern patch from this refreshed series retaining the simpler ssram pointer flow requested in review. - Folded PMT-registration-optional handling onto that simpler flow with no intended functional change. V2 changes: - Update commit message for clarity - Also apply the PCI telemetry path drivers/platform/x86/intel/pmc/ssram_telemetry.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/pla= tform/x86/intel/pmc/ssram_telemetry.c index 1a9f1e67cbe1..8a9c947761b1 100644 --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c @@ -109,6 +109,7 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev,= unsigned int pmc_idx, u3 void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram =3D NULL; void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram =3D NULL; u64 ssram_base; + int ret; =20 ssram_base =3D pci_resource_start(pcidev, 0); tmp_ssram =3D ioremap(ssram_base, SSRAM_HDR_SIZE); @@ -128,7 +129,6 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev,= unsigned int pmc_idx, u3 ssram =3D ioremap(ssram_base, SSRAM_HDR_SIZE); if (!ssram) return -ENOMEM; - } else { ssram =3D no_free_ptr(tmp_ssram); } @@ -136,7 +136,11 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev= , unsigned int pmc_idx, u3 pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx); =20 /* Find and register and PMC telemetry entries */ - return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram); + ret =3D pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram); + if (ret) + dev_warn(&pcidev->dev, "could not register PMT\n"); + + return 0; } =20 static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev) @@ -209,7 +213,7 @@ static int pmc_ssram_telemetry_acpi_init(struct pci_dev= *pcidev, =20 ret =3D intel_vsec_register(&pcidev->dev, &info); if (ret) - return ret; + dev_warn(&pcidev->dev, "could not register PMT\n"); =20 return pmc_ssram_telemetry_get_pmc_acpi(pcidev, index); } --=20 2.43.0