From: sashiko-bot@kernel.org
To: "Maxwell Doose" <m32285159@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: chemical: sensirion,scd30: Update maintainers field
Date: Fri, 15 May 2026 01:20:25 +0000 [thread overview]
Message-ID: <20260515012025.BA4C8C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260515011639.28570-1-m32285159@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to replace Tomasz Duszynski with Maxwell Doose as the maintainer of the SCD30 driver, but it only updates the Device Tree binding YAML file. The global `MAINTAINERS` file was not updated.
--
commit 93a32c5e87f9412329bac834ecc989bf06a6129d
Author: Maxwell Doose <m32285159@gmail.com>
dt-bindings: iio: chemical: sensirion,scd30: Update maintainers field
This commit updates the maintainers field in the Sensirion SCD30 device
tree binding to reflect a change in maintainership.
Link: https://lore.kernel.org/linux-iio/20260507172404.80435-1-m32285159@gmail.com/
> Tomasz Duszynski is no longer the maintainer of the SCD30 driver.
> Replace his entry with mine.
The commit message indicates a change in maintainership for the SCD30 driver,
but this patch only updates the device tree binding file.
Should the SENSIRION SCD30 CARBON DIOXIDE SENSOR DRIVER entry in the global
MAINTAINERS file also be updated?
If the global MAINTAINERS file is left unupdated, tools like get_maintainer.pl
will continue to route patches for the driver's C files to the old maintainer.
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> index 40d87346ff4cf..a5b0debe85b1a 100644
> --- a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Sensirion SCD30 carbon dioxide sensor
>
> maintainers:
> - - Tomasz Duszynski <tomasz.duszynski@octakon.com>
> + - Maxwell Doose <m32285159@gmail.com>
>
> description: |
> Air quality sensor capable of measuring co2 concentration, temperature
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515011639.28570-1-m32285159@gmail.com?part=1
prev parent reply other threads:[~2026-05-15 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 1:16 [PATCH v2] dt-bindings: iio: chemical: sensirion,scd30: Update maintainers field Maxwell Doose
2026-05-15 1:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515012025.BA4C8C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=m32285159@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.