From: Qi Tang <tpluszz77@gmail.com>
To: paul@paul-moore.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org, lyutoon@gmail.com,
horms@kernel.org, huw@codeweavers.com, casey@schaufler-ca.com,
linux-security-module@vger.kernel.org,
Qi Tang <tpluszz77@gmail.com>
Subject: Re: [PATCH net 3/4] netlabel: validate CALIPSO option against skb tail in netlbl_skbuff_getattr
Date: Fri, 15 May 2026 10:42:16 +0800 [thread overview]
Message-ID: <20260515024216.203957-1-tpluszz77@gmail.com> (raw)
In-Reply-To: <CAHC9VhR52b2FbD-aiMFsaXwwRrUGTLSdRFzWcVAZjUm-K3qgkw@mail.gmail.com>
Agreed, -EINVAL is right. The bytes passed parse-time
validation, so hitting either bounds check at consume time means
they were mutated after parse. Treating such a packet as "no
label" via netlbl_unlabel_getattr() drops it into the wrong
default. v2 returns -EINVAL on both checks.
Will also drop the Smack mention from the commit message (Casey
flagged that separately).
Qi
prev parent reply other threads:[~2026-05-15 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 16:51 [PATCH net 3/4] netlabel: validate CALIPSO option against skb tail in netlbl_skbuff_getattr Qi Tang
2026-05-14 17:11 ` Casey Schaufler
2026-05-15 1:54 ` Qi Tang
2026-05-15 2:18 ` Paul Moore
2026-05-15 2:42 ` Qi Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515024216.203957-1-tpluszz77@gmail.com \
--to=tpluszz77@gmail.com \
--cc=casey@schaufler-ca.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=huw@codeweavers.com \
--cc=kuba@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lyutoon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.