From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
linux-nvme@lists.infradead.org, bmarzins@redhat.com
Subject: Re: [PATCH] nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs
Date: Fri, 15 May 2026 06:45:29 +0200 [thread overview]
Message-ID: <20260515044529.GA4003@lst.de> (raw)
In-Reply-To: <20260513095030.2771178-1-john.g.garry@oracle.com>
On Wed, May 13, 2026 at 09:50:30AM +0000, John Garry wrote:
> Use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE instead of
> DEFINE_SYSFS_GROUP_VISIBLE, which means that we can drop
> multipath_sysfs_attr_visible().
>
> Incidentally, multipath_sysfs_attr_visible() should have returned a
> umode_t.
Looks ok, although all the magic symbol name concatenation in the
sysfs code drives me a bit crazy.
Signed-off-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-05-15 4:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:50 [PATCH] nvme: use DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE for multipath_sysfs John Garry
2026-05-15 4:45 ` Christoph Hellwig [this message]
2026-05-15 8:34 ` John Garry
2026-05-15 11:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515044529.GA4003@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=bmarzins@redhat.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.